chore: add modifications to staging automatically after eslint fix#113443
Merged
suchcodemuchwow merged 4 commits intoelastic:masterfrom Oct 1, 2021
suchcodemuchwow:precommit-stage-lint-fixes
Merged
chore: add modifications to staging automatically after eslint fix#113443suchcodemuchwow merged 4 commits intoelastic:masterfrom suchcodemuchwow:precommit-stage-lint-fixes
suchcodemuchwow merged 4 commits intoelastic:masterfrom
suchcodemuchwow:precommit-stage-lint-fixes
Conversation
mistic
added
auto-backport
spalger
approved these changes
Sep 29, 2021
After precommit hook runs with --fix flag changes are not added to staging. However it also does not validate staging area since eslint is only looking for last changes on file not staging area this results fellows to commit with linting errors which fails in CI. This commit resolves this issue by adding fixed files right after linting to staging area. Closes #52722
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Sep 30, 2021
Contributor
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2021
…lastic#113443) After precommit hook runs with --fix flag changes are not added to staging. However it also does not validate staging area since eslint is only looking for last changes on file not staging area this results fellows to commit with linting errors which fails in CI. This commit resolves this issue by adding fixed files right after linting to staging area. Closes elastic#52722 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2021
…113443) (#113611) After precommit hook runs with --fix flag changes are not added to staging. However it also does not validate staging area since eslint is only looking for last changes on file not staging area this results fellows to commit with linting errors which fails in CI. This commit resolves this issue by adding fixed files right after linting to staging area. Closes #52722 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Baturalp Gurdin <9674241+suchcodemuchwow@users.noreply.github.com>
3 tasks
Member
|
Sorry @suchcodemuchwow, had to revert this change. It resulted in rather unexpected failures for other PRs with errors like: The error seems similar to what happens if you directly pass the SCSS to eslint |
Contributor
Author
|
Hey @tylersmalley, I'm not quite sure how it happened and if linting error happens it should have yelled & cancel the commit even before committing locally. The Linting process/PR change works in this way:
Note: |
Contributor
|
Unreverted, looks like issue was actually in #113300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52722
After precommit hook runs with
--fixflag changes are not added to staging. However it also does notvalidate staging area since eslint is only looking for last changes on file not staging area this
results fellows to commit with linting errors which fails in CI. This commit resolves this issue by
adding fixed files right after linting to staging area.