Skip to content

[Canvas] Enable ML Embeddables in Canvas #113309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cqliu1 wants to merge 1 commit into from
Closed

[Canvas] Enable ML Embeddables in Canvas #113309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions x-pack/plugins/canvas/public/components/workpad_header/editor_menu/editor_menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,7 @@ export const EditorMenu: FC<Props> = ({ addElement }) => {
const factories = embeddablesService
? Array.from(embeddablesService.getEmbeddableFactories()).filter(
({ type, isEditable, canCreateNew, isContainerType }) =>
isEditable() &&
!isContainerType &&
canCreateNew() &&
!['visualization', 'ml'].some((factoryType) => {
return type.includes(factoryType);
})
isEditable() && !isContainerType && canCreateNew() && type !== 'visualization'
)
: [];

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/canvas/public/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import { PluginInitializerContext } from 'kibana/public';
import { CoreStart } from '../../../../src/core/public';
import { CanvasServices } from './services';
import { CanvasSetup, CanvasStart, CanvasStartDeps, CanvasPlugin } from './plugin';
export { CANVAS_APP } from '../common/lib/constants';

export { CanvasSetup, CanvasStart };

export interface WithKibanaProps {
kibana: {
services: CoreStart & CanvasStartDeps & { canvas: CanvasServices };
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/ml/kibana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"server": true,
"ui": true,
"requiredBundles": [
"canvas",
"esUiShared",
"kibanaUtils",
"kibanaReact",
Expand Down
5 changes: 3 additions & 2 deletions x-pack/plugins/ml/public/embeddables/common/resolve_job_selection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
} from '../../../../../../src/plugins/kibana_react/public';
import { getMlGlobalServices } from '../../application/app';
import { DashboardConstants } from '../../../../../../src/plugins/dashboard/public';
import { CANVAS_APP } from '../../../../../../x-pack/plugins/canvas/public';
import { JobId } from '../../../common/types/anomaly_detection_jobs';
import { JobSelectorFlyout } from './components/job_selector_flyout';

Expand Down Expand Up @@ -90,8 +91,8 @@ export async function resolveJobSelection(
}
); // Close the flyout when user navigates out of the dashboard plugin

currentAppId$.pipe(takeUntil(from(flyoutSession.onClose))).subscribe((appId) => {
if (appId !== DashboardConstants.DASHBOARDS_ID) {
currentAppId$.pipe(takeUntil(from(flyoutSession.onClose))).subscribe((appId = '') => {
if (![DashboardConstants.DASHBOARDS_ID, CANVAS_APP].includes(appId)) {
flyoutSession.close();
}
});
Expand Down