Removes support for unused optimize.* settings from core deprecations#113296
Merged
TinaHeiligers merged 3 commits intoelastic:masterfrom Sep 28, 2021
Conversation
TinaHeiligers
added
release_note:breaking
Team:Core
lukeelmers
reviewed
Sep 28, 2021
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM, added two (optional) wording suggestions
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
lukeelmers
approved these changes
Sep 28, 2021
Contributor
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
LGTM.
fyi @elastic/kibana-operations
jbudz
approved these changes
Sep 28, 2021
Contributor
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
TinaHeiligers
deleted the
config-breaking/remove-deprecated-configs-optimizer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #103915
The legacy optimizer was removed in #73154 and the configuration settings for that were deprecated as
unused.As of 8.0, Kibana won't support the legacy
optimize.*settings anymore and will fail to start if any of those are configured.This PR removes support for the following configurations:
optimize.lazy,optimize.lazyPort,optimize.lazyHost,optimize.lazyPrebuild,optimize.lazyProxyTimeout,optimize.enabled,optimize.bundleFilter,optimize.bundleDir,optimize.viewCaching,optimize.watch,optimize.watchPort,optimize.watchHost,optimize.watchPrebuild,optimize.watchProxyTimeout,optimize.useBundleCache,optimize.sourceMaps,optimize.workers,optimize.profile,optimize.validateSyntaxOfNodeModulesScreen shots (docs)
In breaking changes in 8.0:
Release note
Legacy
optimize.*settings are no longer supported. Configurations with any of the following legacyoptimize.*settings will prevent Kibana from starting up. Going forward, to run the@kbn/optimizerseparately in development, pass--no-optimizertoyarn start. See #73154 for more details.