Detection Rule Exception List telemetry#113239
Merged
Conversation
pjhampton
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
pjhampton
commented
Sep 28, 2021
x-pack/plugins/security_solution/server/lib/telemetry/receiver.ts
Outdated
Show resolved
Hide resolved
…elastic/kibana into pjhampton/detection-rule-exception-list
donaherc
approved these changes
Sep 30, 2021
Contributor
donaherc
left a comment
donaherc
left a comment
There was a problem hiding this comment.
Nice this LGTM architecturally and is in keeping with the existing tasks. Had a couple of superficial questions about things, but generally nothing stood out for concern. This is going to be extremely useful telemetry data going forward as we get the Insights stuff off the ground. @bfilar, @SourinPaul, and I were talking today about how the Insights data will need Rule contents as well as the existing alert telemetry to ensure we get the maximum value. Thanks!
x-pack/plugins/security_solution/server/lib/telemetry/helpers.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/telemetry/tasks/detection_rule.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream CI is more flaky than usual 👎 |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @pjhampton |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2021
* Add telemetry for detection rule exception lists to improve UX. * Add length for debugging. * Fix type. * Clean up exception list telemetry document. * Dynamically set kibana index (just in case). * Update task title. * Rename version to rule_version. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2021
* Add telemetry for detection rule exception lists to improve UX. * Add length for debugging. * Fix type. * Clean up exception list telemetry document. * Dynamically set kibana index (just in case). * Update task title. * Rename version to rule_version. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Hampton <pjhampton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For users opted in we will collect detection rule exception list telemetry to understand how our users are using the lists feature and to iterate on our detection rules. PII + List item descriptions omitted for privacy.
Checklist
Delete any items that are not applicable to this PR.
For maintainers