[Lens] Thresholds: auto fit thresholds into vertical axis#113238
Merged
dej611 merged 8 commits intoelastic:masterfrom Oct 6, 2021
Merged
[Lens] Thresholds: auto fit thresholds into vertical axis#113238dej611 merged 8 commits intoelastic:masterfrom
dej611 merged 8 commits intoelastic:masterfrom
Conversation
dej611
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
stratoula
approved these changes
Oct 5, 2021
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
This looks fine! Code LGTM, I tested it locally and works as it is described in the issue.
About the padding I don't have strong opinion. It would make sense to me but then we should decide the padding value.
@ghudgins how do you feel about it?
| max = extent.upperBound; | ||
| } | ||
| } else { | ||
| const axisHasTreshold = thresholdLayers.some(({ yConfig }) => |
Contributor
There was a problem hiding this comment.
nit: typo, axisHasThreshold :D
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2021
…3238) * ✨ Make threshold fit into view automatically * 🐛 do not compute axis threshold extends if no threshold is present * ✅ One more fix for 0-based extends and tests * 📝 fix typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2021
…114104) * ✨ Make threshold fit into view automatically * 🐛 do not compute axis threshold extends if no threshold is present * ✅ One more fix for 0-based extends and tests * 📝 fix typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #112795
This PR includes thresholds into the vertical axis computation to fit them together with the data.
Main points:
Note 1:
Does it make sense add some padding to the extends in cases as the ones below?
Note 2: the auto extends does not apply for the horizontal axis:
Checklist
Delete any items that are not applicable to this PR.