[Fleet] Register Sample Data by thomasneirynck · Pull Request #113200 · elastic/kibana

thomasneirynck · 2021-09-27T23:05:17Z

Summary

Registers sample data. They now display in the Fleet integrations app.

This includes the addition of an svg image type, so it can be handled by the CardIcon-component. EDIT - this generated some suggestions for improvement. Will address these in separate PR.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-09-28T14:20:54Z

Pinging @elastic/fleet (Team:Fleet)

This reverts commit 68e286f.

kpollich

LGTM 🚀

x-pack/plugins/fleet/public/applications/integrations/sections/epm/components/package_card.tsx

clintandrewhall

I have a few comments. I'll create a Storybook story, as well, unless you want to try to create one.

x-pack/plugins/fleet/public/components/package_icon.tsx

src/plugins/custom_integrations/common/index.ts

lukeelmers

Overall LGTM, just had a few thoughts

src/plugins/home/server/services/sample_data/lib/register_with_integrations.ts

src/plugins/home/server/services/sample_data/sample_data_registry.ts

…r_sample_data

src/plugins/home/server/services/sample_data/sample_data_registry.test.ts

src/plugins/home/server/services/sample_data/sample_data_registry.ts

…try.test.ts Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

src/plugins/home/server/services/sample_data/lib/sample_dataset_schema.ts

src/plugins/home/server/services/sample_data/sample_data_registry.test.ts

src/plugins/custom_integrations/common/index.ts

src/plugins/home/server/services/sample_data/sample_data_registry.ts

…r_sample_data

lukeelmers

Core changes LGTM. Be sure to run yarn build:apidocs before merging, as the new docs system will need to be updated to reflect the removal of the registerSampleDataset API.

src/plugins/home/server/services/sample_data/sample_data_registry.test.ts

This reverts commit 063f881.

thomasneirynck · 2021-09-29T19:10:30Z

discussed offline with @lukeelmers . The API-doc regeneration is pulling in a lot of changes unrelated to this PR. To reduce clutter here, we will revert the new API-docs from this PR, and put up a separate PR just for the new API docs.

…r_sample_data

kibanamachine · 2021-09-29T22:18:04Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`customIntegrations`	66	69	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	597.8KB	597.8KB	+36.0B

Unknown metric groups

API count

id	before	after	diff
`customIntegrations`	66	69	+3

History

💔 Build #156572 failed 3bcaba9
💚 Build #156491 succeeded 4c84644
💚 Build #156261 succeeded 2ec5fc6
💚 Build #156256 succeeded 2421795
💚 Build #156122 succeeded c35b445

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-09-29T22:24:19Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Thomas Neirynck <thomas@elastic.co>

boilerplate

35d38da

thomasneirynck added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0 labels Sep 27, 2021

thomasneirynck mentioned this pull request Sep 27, 2021

[Fleet] Unified Integrations view #93084

Closed

63 tasks

thomasneirynck added the Feature:Unified Integrations Unified Integrations view feature label Sep 28, 2021

thomasneirynck added 2 commits September 28, 2021 10:03

tmp

68e286f

add integration test

69b5f1f

thomasneirynck requested review from TinaHeiligers, clintandrewhall, joshdover, lukeelmers and pgayvallet and removed request for TinaHeiligers September 28, 2021 14:19

thomasneirynck marked this pull request as ready for review September 28, 2021 14:20

thomasneirynck requested review from a team as code owners September 28, 2021 14:20

thomasneirynck requested a review from kpollich September 28, 2021 14:21

Revert "tmp"

1ec94cb

This reverts commit 68e286f.

kpollich approved these changes Sep 28, 2021

View reviewed changes

x-pack/plugins/fleet/public/applications/integrations/sections/epm/components/package_card.tsx Outdated Show resolved Hide resolved

remove cruft

c35b445

clintandrewhall reviewed Sep 28, 2021

View reviewed changes

x-pack/plugins/fleet/public/components/package_icon.tsx Show resolved Hide resolved

src/plugins/custom_integrations/common/index.ts Show resolved Hide resolved

thomasneirynck mentioned this pull request Sep 28, 2021

[Fleet] Show beats replacements in integration browser #113291

Merged

2 tasks

lukeelmers reviewed Sep 28, 2021

View reviewed changes

thomasneirynck added 2 commits September 28, 2021 17:16

Merge branch 'master' of github.com:elastic/kibana into fleet/registe…

ab705f9

…r_sample_data

feedback

2421795

lukeelmers reviewed Sep 28, 2021

View reviewed changes

src/plugins/home/server/services/sample_data/sample_data_registry.test.ts Outdated Show resolved Hide resolved

src/plugins/home/server/services/sample_data/sample_data_registry.ts Outdated Show resolved Hide resolved

Update src/plugins/home/server/services/sample_data/sample_data_regis…

2ec5fc6

…try.test.ts Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

pgayvallet reviewed Sep 29, 2021

View reviewed changes

src/plugins/home/server/services/sample_data/lib/sample_dataset_schema.ts Outdated Show resolved Hide resolved

src/plugins/home/server/services/sample_data/sample_data_registry.test.ts Outdated Show resolved Hide resolved

joshdover approved these changes Sep 29, 2021

View reviewed changes

src/plugins/custom_integrations/common/index.ts Show resolved Hide resolved

src/plugins/home/server/services/sample_data/sample_data_registry.ts Show resolved Hide resolved

thomasneirynck added 2 commits September 29, 2021 11:15

Merge branch 'master' of github.com:elastic/kibana into fleet/registe…

424b9b1

…r_sample_data

feedback

4c84644

thomasneirynck requested review from clintandrewhall, lukeelmers and pgayvallet September 29, 2021 17:26

lukeelmers approved these changes Sep 29, 2021

View reviewed changes

src/plugins/home/server/services/sample_data/sample_data_registry.test.ts Outdated Show resolved Hide resolved

thomasneirynck added 2 commits September 29, 2021 15:02

regenerate docs

063f881

Revert "regenerate docs"

d3a61d8

This reverts commit 063f881.

improve mock

3bcaba9

thomasneirynck added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 29, 2021

Merge branch 'master' of github.com:elastic/kibana into fleet/registe…

3ee0297

…r_sample_data

thomasneirynck merged commit 1090a35 into elastic:master Sep 29, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021

[Fleet] Register Sample Data (elastic#113200)

e0e8041

kibanamachine mentioned this pull request Sep 29, 2021

[7.x] [Fleet] Register Sample Data (#113200) #113488

Merged

kibanamachine added a commit that referenced this pull request Sep 30, 2021

[Fleet] Register Sample Data (#113200) (#113488)

2f4662b

Co-authored-by: Thomas Neirynck <thomas@elastic.co>

joshdover mentioned this pull request Oct 5, 2021

[Fleet] Add cards for linking to file upload pages #113940

Closed

alexfrancoeur mentioned this pull request Oct 12, 2021

Create title and description based on guidelines for EMS, Sample Data and File Upload #114336

Closed

Conversation

thomasneirynck commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 28, 2021

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lukeelmers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukeelmers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thomasneirynck commented Sep 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Sep 29, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

API count

History

Uh oh!

kibanamachine commented Sep 29, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

thomasneirynck commented Sep 27, 2021 •

edited

Loading

thomasneirynck commented Sep 29, 2021 •

edited

Loading