Skip to content

Fix bulkResolve for aliasMatch outcomes#113188

Merged
jportner merged 2 commits intoelastic:masterfrom
jportner:issue-113160-fix-bulkResolve-issues
Sep 29, 2021
Merged

Fix bulkResolve for aliasMatch outcomes#113188
jportner merged 2 commits intoelastic:masterfrom
jportner:issue-113160-fix-bulkResolve-issues

Conversation

@jportner
Copy link
Copy Markdown
Contributor

@jportner jportner commented Sep 27, 2021

Resolves #113160.

Now, when using the client-side SavedObjectsClient to resolve an object, if that object has an "aliasMatch" outcome, it returns as expected instead of being treated as an error.

This PR fixes unreleased regressions so it is labeled with release_note:skip.

The request objects are still de-duplicated, but now the responses are
matched by request index instead of by object type/id.
@jportner jportner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 27, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 298.4KB 298.4KB +88.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner marked this pull request as ready for review September 29, 2021 16:47
@jportner jportner requested a review from a team as a code owner September 29, 2021 16:47
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review only)

@jportner jportner added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 29, 2021
@jportner jportner merged commit a4d4e5b into elastic:master Sep 29, 2021
@jportner jportner deleted the issue-113160-fix-bulkResolve-issues branch September 29, 2021 17:01
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 29, 2021
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public SavedObjectsClient.resolve fails for "aliasMatch" outcome

3 participants