[optimizer] keep classnames to support constructor.name#113119
Merged
spalger merged 2 commits intoelastic:masterfrom Sep 27, 2021
Merged
[optimizer] keep classnames to support constructor.name#113119spalger merged 2 commits intoelastic:masterfrom
spalger merged 2 commits intoelastic:masterfrom
Conversation
spalger
added
Team:Operations
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsmiscellaneous assets size
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
Sep 27, 2021
spalger
added
the
auto-backport
Contributor
💔 Backport failed
To backport manually run: |
spalger
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com> (cherry picked from commit 6612f2b)
kibanamachine
added a commit
that referenced
this pull request
Sep 27, 2021
… and (#113119) (#112498) * [kbn/optimizer] mangle variables in optimizer bundles (#112435) Co-authored-by: spalger <spalger@users.noreply.github.com> * [optimizer] keep classnames to support constructor.name (#113119) Co-authored-by: spalger <spalger@users.noreply.github.com> (cherry picked from commit 6612f2b) Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#112498 pointed out a flaw in #112435 which wasn't caught by our tests.
constructor.nameis checked in our code but does not work with minified code, which caused object imports to be unable to validate the type of error they were seeing. I'm going to try and lint for this type of check so that we can prevent it in the future (we should just have a knowntypeproperty or something).For now, I'm going to disable mangling class names so that we can get this change backported to 7.16.