add SavedObjectType.management.displayName#113091
Merged
pgayvallet merged 7 commits intoelastic:masterfrom Sep 28, 2021
Merged
Conversation
pgayvallet
added
Feature:Saved Objects Management
Team:Core
Contributor
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
approved these changes
Sep 28, 2021
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Sep 28, 2021
* add `SavedObjectType.management.displayName` * fix unit tests * add FTR test * update generated doc * also update labels * fix unit tests # Conflicts: # src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx # src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx
pgayvallet
added a commit
that referenced
this pull request
Sep 28, 2021
* add `SavedObjectType.management.displayName` (#113091) * add `SavedObjectType.management.displayName` * fix unit tests * add FTR test * update generated doc * also update labels * fix unit tests # Conflicts: # src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx # src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx * fix types * fix allowedTypes usage * fix unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #105575
Introduce a new
management.displayNameoption when registering a SO type to allow type owners to specify the label used for the type in SO management.(Note:
dashboardonly has adisplayNamefor testing and screenshot purposes)Checklist