[Viz] legend duplicates percentile options when chart has both left & right Y axes#113073
Merged
DianaDerevyankina merged 5 commits intoelastic:masterfrom Sep 27, 2021
Merged
Conversation
DianaDerevyankina
added
Feature:XYAxis
DianaDerevyankina
requested review from
Kuznietsov,
VladLasitsa and
alexwizp
Kuznietsov
approved these changes
Sep 27, 2021
Contributor
Kuznietsov
left a comment
Kuznietsov
left a comment
There was a problem hiding this comment.
Excepting the suggestion, the code LGTM. Tested locally, everything works as expected.
| return m; | ||
| }; | ||
|
|
||
| // For percentile aggregation id is coming in the form `%d.%d`, where first `%d` is `id` and the second - `percents` |
Contributor
There was a problem hiding this comment.
Nit: The mistake in this comment is my fault. I'd suggest changing %d.%d to %s.%d. The final comment would be:
- // For percentile, the aggregation id is coming in the form
%s.%d, where%sisagg_idand%d-percents.
Contributor
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
Contributor
Author
|
@elasticmachine merge upstream |
stratoula
reviewed
Sep 27, 2021
| import { Aspect } from '../types'; | ||
| import type { Aspect } from '../types'; | ||
|
|
||
| interface Dimension { |
Contributor
There was a problem hiding this comment.
This type here confuses me because we already have defined a type Dimension in the types folder. Is it different from this type? If yes, it should have a different name. If no, the already existing type should be used
stratoula
approved these changes
Sep 27, 2021
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM! I tested it Chrome and works fine :D
alexwizp
approved these changes
Sep 27, 2021
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Sep 27, 2021
… right Y axes (elastic#113073) * [Viz] legend duplicates percentile options when chart has both left & right Y axes * Update comment for isPercentileIdEqualToSeriesId * Remove Dimension interface * Replace partial aspect with whole aspect value Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
DianaDerevyankina
added a commit
that referenced
this pull request
Sep 27, 2021
… right Y axes (#113073) (#113169) * [Viz] legend duplicates percentile options when chart has both left & right Y axes * Update comment for isPercentileIdEqualToSeriesId * Remove Dimension interface * Replace partial aspect with whole aspect value Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112388
Partial changes from #111378
Summary
The reason for incorrect displaying of chart and its legend was ignoring the case for percentile column id. As it contains percent value after the point, we should take into account only id part before it, while filtering
yAspects.Checklist
For maintainers