Decouples saved objects management from legacy saved objects loaders by TinaHeiligers · Pull Request #113031 · elastic/kibana

TinaHeiligers · 2021-09-23T18:52:04Z

Resolves #67607
The saved objects management plugin no longer supports legacy imports and the edit view has changed to a read-only view.

This PR handles the tech debt of removing the dependency on the loaders completely.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

TinaHeiligers · 2021-09-23T23:06:33Z

src/plugins/saved_objects_management/public/lib/index.ts


 export { fetchExportByTypeAndSearch } from './fetch_export_by_type_and_search';
 export { fetchExportObjects } from './fetch_export_objects';
-export { canViewInApp } from './in_app_url';


Replaced by class method in #112034

TinaHeiligers · 2021-09-23T23:07:01Z

src/plugins/saved_objects_management/public/lib/index.ts

 export { findObjects } from './find_objects';
 export { bulkGetObjects } from './bulk_get_objects';
 export { extractExportDetails, SavedObjectsExportResultDetails } from './extract_export_details';
-export { createFieldList } from './create_field_list';


No longer used

TinaHeiligers · 2021-09-23T23:08:54Z

src/plugins/saved_objects_management/public/management_section/mount_section.tsx


 interface MountParams {
  core: CoreSetup<StartDependencies, SavedObjectsManagementPluginStart>;
-  serviceRegistry: ISavedObjectsManagementServiceRegistry;


We use the raw saved objects directly now and don't need the client-side registry.

TinaHeiligers · 2021-09-23T23:10:18Z

...objects_management/public/management_section/objects_table/components/relationships.test.tsx

            id: '1',
            relationship: 'parent',
            meta: {
-              editUrl: '/management/kibana/objects/savedSearches/1',


I missed these in #112034

TinaHeiligers · 2021-09-23T23:12:05Z

src/plugins/saved_objects_management/public/plugin.ts

        description: i18n.translate('savedObjectsManagement.objects.savedObjectsDescription', {
-          defaultMessage:
-            'Import, export, and manage your saved searches, visualizations, and dashboards.',
+          defaultMessage: 'Import, export, and manage your saved objects.',


We support all registered saved object types and aren't restricted to those using the loaders anymore.

You need to delete the key from the translation files for it to be picked for re-translation

TinaHeiligers · 2021-09-23T23:36:21Z

src/plugins/saved_objects_management/tsconfig.json

    { "path": "../kibana_react/tsconfig.json" },
    { "path": "../management/tsconfig.json" },
-    { "path": "../visualizations/tsconfig.json" },
+    { "path": "../saved_objects_tagging_oss/tsconfig.json" },


We were indirectly inheriting the saved_objects_tagging_oss types from the visualizations plugin. With the visualizations dependency gone, we need to declare it explicitly.

TinaHeiligers

self review

TinaHeiligers · 2021-09-24T18:37:36Z

FYI @flash1293

TinaHeiligers · 2021-09-26T19:28:36Z

@elasticmachine merge upstream

pgayvallet

LGTM

pgayvallet · 2021-09-25T21:04:05Z

src/plugins/saved_objects_management/kibana.json

  "server": true,
  "ui": true,
  "requiredPlugins": ["management", "data"],
-  "optionalPlugins": ["dashboard", "visualizations", "discover", "home", "savedObjectsTaggingOss", "spaces"],


pgayvallet · 2021-09-27T06:22:16Z

src/plugins/saved_objects_management/public/plugin.ts

        description: i18n.translate('savedObjectsManagement.objects.savedObjectsDescription', {
-          defaultMessage:
-            'Import, export, and manage your saved searches, visualizations, and dashboards.',
+          defaultMessage: 'Import, export, and manage your saved objects.',


You need to delete the key from the translation files for it to be picked for re-translation

pgayvallet · 2021-09-27T06:24:05Z

src/plugins/saved_objects_management/public/management_section/types.ts

 export interface ObjectField {
  type: FieldType;
  name: string;
  value: any;
 }

 export type FieldType = 'text' | 'number' | 'boolean' | 'array' | 'json';


From a quick grep, I think ObjectField and FieldType are also no longer used?

You're right! This also means we can delete the whole file 😄

kibanamachine · 2021-09-27T17:36:02Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`savedObjectsManagement`	95	91	-4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`savedObjectsManagement`	91	85	-6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`savedObjectsManagement`	83.7KB	83.6KB	-54.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`savedObjectsManagement`	18.4KB	15.8KB	-2.6KB

Unknown metric groups

API count

id	before	after	diff
`savedObjectsManagement`	104	98	-6

References to deprecated APIs

id	before	after	diff
`savedObjectsManagement`	27	17	-10

History

💚 Build #155602 succeeded 197a3a1
💚 Build #155453 succeeded 0cd807b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers added 2 commits September 23, 2021 11:40

Decouples saved objects management from legacy saved objects loaders

c42616a

Removes dependencies and code no longer required

0cd807b

TinaHeiligers added Feature:Saved Objects Management release_note:skip Skip the PR/issue when compiling release notes v8.0.0 backport:skip This PR does not require backporting labels Sep 23, 2021

TinaHeiligers marked this pull request as ready for review September 23, 2021 21:43

TinaHeiligers requested a review from a team as a code owner September 23, 2021 21:43

TinaHeiligers commented Sep 23, 2021

View reviewed changes

Merge branch 'master' into so-management/decouple-loaders

197a3a1

pgayvallet approved these changes Sep 27, 2021

View reviewed changes

TinaHeiligers added 2 commits September 27, 2021 08:29

Removes changed i18n key from translation files

e32d152

Removes unused types from management_section

73c2769

TinaHeiligers enabled auto-merge (squash) September 27, 2021 15:40

TinaHeiligers merged commit 96379a5 into elastic:master Sep 27, 2021

TinaHeiligers deleted the so-management/decouple-loaders branch September 27, 2021 17:37

Conversation

TinaHeiligers commented Sep 23, 2021

Checklist

For maintainers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

TinaHeiligers commented Sep 24, 2021

Uh oh!

TinaHeiligers commented Sep 26, 2021

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 27, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

References to deprecated APIs

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants