Skip to content

[User Experience app] Simplify page header responsiveness in ux app#112930

Merged
shahzad31 merged 3 commits intoelastic:masterfrom
shahzad31:fix-ux-dashboard-heading
Sep 28, 2021
Merged

[User Experience app] Simplify page header responsiveness in ux app#112930
shahzad31 merged 3 commits intoelastic:masterfrom
shahzad31:fix-ux-dashboard-heading

Conversation

@shahzad31
Copy link
Contributor

Summary

Fix #111837

Simplify page header responsivenss in user experience app

image

Testing

  • Please test on all screen breakpoints

@shahzad31 shahzad31 marked this pull request as ready for review September 23, 2021 08:47
@shahzad31 shahzad31 requested a review from a team September 23, 2021 08:47
@shahzad31 shahzad31 requested a review from a team as a code owner September 23, 2021 08:47
@shahzad31 shahzad31 self-assigned this Sep 23, 2021
@shahzad31 shahzad31 added v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 23, 2021
@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.7MB 2.7MB -289.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer! Looks great. LGTM.

Copy link
Contributor

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, environment filter still looks the same in the APM app

@shahzad31 shahzad31 merged commit 62e7dee into elastic:master Sep 28, 2021
@shahzad31 shahzad31 deleted the fix-ux-dashboard-heading branch September 28, 2021 11:56
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 28, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 28, 2021
…lastic#112930)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 28, 2021
…112930) (#113252)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
@shahzad31 shahzad31 added v7.15.0 v7.15.1 auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Oct 5, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.15 Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 112930

shahzad31 added a commit that referenced this pull request Oct 5, 2021
…x app (#112930) (#113973)

* [User Experience app] Simplify page header responsiveness in ux app (#112930)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.15.0 v7.15.1 v7.16.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[User experience app] Header looks broken/not responsive

5 participants