-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Reporting/Chromium] Update Puppeteer to 10.2.0, use downloaded Chromium for Mac x64/arm #112905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting/Chromium] Update Puppeteer to 10.2.0, use downloaded Chromium for Mac x64/arm #112905
Conversation
1b8f80f to
167fb15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the revision is mainly what causes Kibana to download the correct version of chromium to match the version needed for Puppeteer.
This PR changes the interface of the "packages" in this set by having them specify their own revision. The reason is because https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html doesn't actually hold builds for all platforms and architectures for every revision. For Mac Arm64, we have to find a "close enough" revision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file are to refine the logging, and handling referencing each downloaded browser in a folder based on the architecture type.
49af1f1 to
055a0dd
Compare
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
a8de0ff to
b1b433d
Compare
|
@tsullivan is starting review on this an option? I'm hoping we can coordinate artifact signing in parallel. |
Yes, but only the Mac setup is reviewable at this moment. There's now a TODO in the description that we need to create a a new Linux build for this update |
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
jloleysens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally on macOS and seems to be working as expected, however I was not able to get the build by running yarn kbn build --skip-os-packages because I couldn't find the out dir 😅 . I tested using node ./scripts/build.js --skip-os-packages which provided the build that I ran and generated reports with.
jbudz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged this into #114879 and tested on an ARM Mac.
Reports generated fine. Diagnostics timed out at the capture screenshot step - not sure if is a selector needs to be updated globally or if it's just for me. I'll circle back in further testing.
jbudz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed the issue above wasn't limited to macos or the changes here. Opened #115107
LGTM
|
When those changes get pushed, we can get distributables from buildkite-ci and ci:build-all-platforms labels if you're interested. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
expected head sha didn’t match current head ref. |
|
@elasticmachine merge upstream |
|
This PR is ready to merge, pending updates that need to happen within the Infra environment to ensure the Mac releases that bundle with Chromium.app are notarized by Apple. |
|
This is currently on hold while we look into creating a new custom build for Mac x64/arm |
…ser-off-the-shelf
|
Unfortunately, it looks like we will not be able to change to using the downloaded version of Chromium for Mac, or add support for ARM on Mac. I'm going to close this PR in order to file a change that updates to Puppeteer 10 without any changes to the source of the Chromium binary for Mac. |
|
Closed for #115682 |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts.saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboardStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
This PR updates the Puppeteer dependency for Reporting to 10.2.0, and while doing so, switches the source of Chrome software for Mac to pull the download from https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html
Making the switch to use the "off-the-shelf" Chromium software for Mac allows us to easily add support for Mac on ARM architecture since there is no additional custom build for Elastic to create.
Closes #100429
Closes #109949
Closes #109545
Testing
yarn kbn build --skip-os-packages./bin/kibanaStart complete, these should be the only Reporting-specific logs:TODO
revision: 856583in the code