[Actions][Docs] Modify connector documentation with the new MS Exchange online configuration requirements by YulNaumenko · Pull Request #112768 · elastic/kibana

YulNaumenko · 2021-09-22T00:59:31Z

This PR is adding documentation for Microsoft Exchange email connector and UI placeholders with help links.
Link for testing docs: https://kibana_112768.docs-preview.app.elstc.co/guide/en/kibana/master/email-action-type.html#exchange

### Checklist

Delete any items that are not applicable to this PR.

Documentation was added for features that require explanation or tutorials

…ge online configuration requirements

…ge_docs

elasticmachine · 2021-09-27T03:01:32Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko · 2021-09-28T15:55:16Z

@elasticmachine merge upstream

ymao1 · 2021-09-30T12:18:38Z

What do you think about moving this to a separate sub-page? This section takes up a lot of space now. Interested to hear what @elastic/kibana-docs think as well.

docs/management/connectors/action-types/email.asciidoc

YulNaumenko · 2021-10-04T17:34:53Z

@elasticmachine merge upstream

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

YulNaumenko · 2021-10-04T18:30:30Z

What do you think about moving this to a separate sub-page? This section takes up a lot of space now. Interested to hear what @elastic/kibana-docs think as well.

@ymao1 your suggestion makes sense, but in this case we will get more nested levels of the docs which is worse supported by the new documents system. @gchaps any thoughts on this? Can we have it as it is or a better approach will be a splitting provider specific docs to a subpages?

docs/management/connectors/action-types/email.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

gchaps · 2021-10-04T22:16:42Z

for now, i would leave the page as is. the hierarchy in the new docs system will be much flatter. we can revisit after we move the docs.

gchaps

lgtm

ymao1

Docs look great! Left one comment about adding some separation between the deprecated config and the new config and there is one screenshot on the email docs page that would be nice to update with a new screenshot showing the service dropdown.

docs/management/connectors/action-types/email.asciidoc

kibanamachine · 2021-10-06T05:55:34Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	757.7KB	758.7KB	+979.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	298.7KB	298.8KB	+167.0B

History

💚 Build #157792 succeeded 5748aaa
💚 Build #157717 succeeded cca5420
💔 Build #156151 failed 5670656
💚 Build #155617 succeeded 37f8698

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

ymao1

LGTM!

ymao1

It would help if I click Approve :)

chrisronline

LGTM!

chrisronline · 2021-10-05T20:38:43Z

docs/management/connectors/action-types/email.asciidoc

+[role="screenshot"]
+image::management/connectors/images/exchange-secrets.png[MS Exchange secrets configuration]
+
+Add a new client secret, then copy the value and put it to the proper field in the Microsoft Exchange email connector.


Should we add a screenshot of where this goes in the UI?

I think we have a bunch now, probably when the SDH comes :-)

…ge online configuration requirements (elastic#112768) * [Actions][Docs] Modify connector documentation with the new MS Exchange online configuration requirements * Added images * Added client secrets * fixed test * fixed links * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fixed due to comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update email.asciidoc * fixed due to comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

…ge online configuration requirements (#112768) (#114170) * [Actions][Docs] Modify connector documentation with the new MS Exchange online configuration requirements * Added images * Added client secrets * fixed test * fixed links * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fixed due to comments * Apply suggestions from code review Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update email.asciidoc * fixed due to comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

[Actions][Docs] Modify connector documentation with the new MS Exchan…

d639d6d

…ge online configuration requirements

YulNaumenko self-assigned this Sep 22, 2021

YulNaumenko added 2 commits September 25, 2021 21:46

Merge remote-tracking branch 'upstream/master' into actions_ms_exchan…

cbac5fa

…ge_docs

Added images

9d08be3

YulNaumenko added documentation Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX v7.16.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 27, 2021

YulNaumenko marked this pull request as ready for review September 27, 2021 03:01

YulNaumenko requested review from a team as code owners September 27, 2021 03:01

YulNaumenko requested a review from gchaps September 27, 2021 03:01

YulNaumenko added 3 commits September 26, 2021 20:11

Added client secrets

287d83a

fixed test

5417af8

fixed links

37f8698

pgayvallet approved these changes Sep 27, 2021

View reviewed changes

Merge branch 'master' into actions_ms_exchange_docs

5670656

YulNaumenko requested a review from a team September 28, 2021 16:12

gchaps reviewed Oct 1, 2021

View reviewed changes

kibanamachine and others added 3 commits October 4, 2021 13:34

Merge branch 'master' into actions_ms_exchange_docs

d839656

Apply suggestions from code review

2f9975f

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

fixed due to comments

cca5420

YulNaumenko requested a review from gchaps October 4, 2021 18:22

gchaps reviewed Oct 4, 2021

View reviewed changes

Apply suggestions from code review

f394873

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update email.asciidoc

5748aaa

gchaps approved these changes Oct 4, 2021

View reviewed changes

ymao1 reviewed Oct 5, 2021

View reviewed changes

docs/management/connectors/action-types/email.asciidoc Show resolved Hide resolved

fixed due to comments

b59e8a0

YulNaumenko requested a review from ymao1 October 6, 2021 03:48

ymao1 reviewed Oct 6, 2021

View reviewed changes

ymao1 approved these changes Oct 6, 2021

View reviewed changes

chrisronline approved these changes Oct 6, 2021

View reviewed changes

YulNaumenko merged commit b9db370 into elastic:master Oct 6, 2021

YulNaumenko mentioned this pull request Oct 6, 2021

[7.x] [Actions][Docs] Modify connector documentation with the new MS Exchange online configuration requirements (#112768) #114170

Merged

lcawl mentioned this pull request Jul 12, 2023

[DOCS] Improve connectors content #140222

Closed

9 tasks

Conversation

YulNaumenko commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Sep 27, 2021

Uh oh!

YulNaumenko commented Sep 28, 2021

Uh oh!

ymao1 commented Sep 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YulNaumenko commented Oct 4, 2021

Uh oh!

YulNaumenko commented Oct 4, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gchaps commented Oct 4, 2021

Uh oh!

gchaps left a comment

Choose a reason for hiding this comment

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Oct 6, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

chrisronline Oct 5, 2021

Choose a reason for hiding this comment

Uh oh!

YulNaumenko Oct 6, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

YulNaumenko commented Sep 22, 2021 •

edited

Loading