Skip to content

[App Search] Add document position indicator to Result component#112759

Merged
byronhulcher merged 4 commits intoelastic:masterfrom
daveyholler:result-position-indicator
Sep 28, 2021
Merged

[App Search] Add document position indicator to Result component#112759
byronhulcher merged 4 commits intoelastic:masterfrom
daveyholler:result-position-indicator

Conversation

@daveyholler
Copy link
Contributor

@daveyholler daveyholler commented Sep 21, 2021

Summary

Adds a result position indicator to the ResultHeader component.

image

Checklist

@daveyholler daveyholler changed the title Document position indicator. Document position indicator Sep 21, 2021
@byronhulcher byronhulcher changed the title Document position indicator [App Search] Add document position indicator to Result component Sep 22, 2021
@byronhulcher byronhulcher added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins v7.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 22, 2021
@daveyholler daveyholler marked this pull request as ready for review September 22, 2021 15:11
@daveyholler daveyholler requested a review from a team September 22, 2021 15:11
@byronhulcher
Copy link
Contributor

@elasticmachine merge upstream

@byronhulcher byronhulcher requested review from JasonStoltz and removed request for JasonStoltz September 28, 2021 12:07
@byronhulcher byronhulcher enabled auto-merge (squash) September 28, 2021 12:08
@byronhulcher byronhulcher enabled auto-merge (squash) September 28, 2021 12:16
@byronhulcher
Copy link
Contributor

Sorry for a lot of noise. I've made decision to merge as-is and created a follow-up issue to add this to the proper views once we've built those views. Thanks for building this out @daveyholler, it will merge as soon as tests pass.

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB +316.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @daveyholler @byronhulcher

kibanamachine added a commit that referenced this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants