Fixes #11232 - Add option for panel and global filters to annotations for TSVB #11260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
Feature:TSVB
alexfrancoeur
approved these changes
Apr 17, 2017
alexfrancoeur
left a comment
alexfrancoeur
left a comment
There was a problem hiding this comment.
@simianhacker Functionality, the feature seems to work as expected. I'm wondering if we could adjust the label a bit for configuring. Instead of having Include Global Filters and Include Panel Filters what if we switched the logic around and had Ignore Global Filters and Ignore Panel Filters with the default value being Yes. This might be a bit easier for the user to understand, what do you think?
Member
Author
|
@alexfrancoeur I changed to ignore vs include per request |
simianhacker
force-pushed
the
issue-11232
branch
from
ddf83ca to
f3e3ec3
Compare
|
@simianhacker fantastic - LGTM 👍 |
simianhacker
added a commit
that referenced
this pull request
Apr 24, 2017
Member
Author
|
Back ported to 5.x with f49b750 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11232 by adding an two separate options for including panel and global filters for annotations for TSVB.