[Canvas] Move workpad components to typescript#112556
Merged
crob611 merged 3 commits intoelastic:masterfrom Sep 28, 2021
Merged
[Canvas] Move workpad components to typescript#112556crob611 merged 3 commits intoelastic:masterfrom
crob611 merged 3 commits intoelastic:masterfrom
Conversation
crob611
added
review
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
crob611
changed the title
crob611
force-pushed
the
convert-workpad-to-typescript
branch
from
cdde189 to
81c343f
Compare
poffdeluxe
approved these changes
Sep 27, 2021
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 28, 2021
* Move workpad components to typescript * Fix types Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the workpad container and component to typescript, as well as removing recompose from workpad container in favor of hooks.
Testing
There should be no functional or visual changes to the user from these changes. The important thing to test is that the workpad still shows up and functions as expected. Also that all workpad shortcuts work as expected.