[Transform] Transforms health alerting rule type by darnautov · Pull Request #112277 · elastic/kibana

darnautov · 2021-09-15T14:01:55Z

Summary

Part of #111945

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

...ugins/transform/public/alerting/transform_health_rule_type/register_transform_health_rule.ts

...ugins/transform/public/alerting/transform_health_rule_type/transform_health_rule_trigger.tsx

.../plugins/transform/public/alerting/transform_health_rule_type/transform_selector_control.tsx

x-pack/plugins/transform/server/lib/alerting/register_transform_alerting_rules.ts

...ugins/transform/public/alerting/transform_health_rule_type/register_transform_health_rule.ts

...plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.ts

…health-alerting-rule

matschaffer

Seems generally good to me. It might be good for @mgiota or @miltonhultgren to cross check given they've been doing more in the infra UI alerting space.

matschaffer · 2021-10-05T06:18:35Z

x-pack/plugins/monitoring/server/plugin.ts

  }

  registerPluginInUI(plugins: PluginsSetup) {
+    const alertingRules = [...RULES, TRANSFORM_RULE_TYPE.TRANSFORM_HEALTH];


Is there a reason we're not adding TRANSFORM_RULE_TYPE.TRANSFORM_HEALTH to the RULES constant directly?

I tried it at first but RULES are used by the factory here. So it requires extending the BaseRule class which I assume is redundant for the Transform alerting rule.

darnautov · 2021-10-05T13:48:24Z

@elasticmachine merge upstream

YulNaumenko · 2021-10-05T16:06:13Z

x-pack/plugins/monitoring/server/plugin.ts

    for (const alert of alerts) {
      plugins.alerting?.registerType(alert.getRuleType());
    }
+    plugins.alerting?.registerType(getTransformHealthRuleType());


Is there any specific reason to do not use a factory?

We discussed it and realized it's not a right fit for the Stack Monitoring rules. We're going to include it in the Stack Rules instead.

YulNaumenko

I think we should update the rules telemetry list x-pack/plugins/alerting/server/usage/alerts_usage_collector.ts as well and create a proper update in the telemetry repository, for example: https://github.com/elastic/telemetry/pull/530

darnautov · 2021-10-06T12:59:21Z

thanks, @YulNaumenko, I've updated mappings in de0a7d9. Also realized there were some issues with the ML related mappings 😓

YulNaumenko

LGTM

kibanamachine · 2021-10-06T16:04:08Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`transform`	227	235	+8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`transform`	0	4	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`transform`	308.7KB	322.1KB	+13.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`transform`	0	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	299.3KB	299.4KB	+78.0B
`transform`	12.2KB	15.5KB	+3.3KB
total			+3.4KB

Unknown metric groups

API count

id	before	after	diff
`transform`	0	4	+4

async chunk count

id	before	after	diff
`transform`	1	3	+2

History

💔 Build #158445 failed 0d5253c
💔 Build #158410 failed c363b2c
💔 Build #158439 failed de0a7d9
💔 Build #158401 failed a6d8fe6
💚 Build #158027 succeeded 621f45a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

kibanamachine · 2021-10-06T16:36:13Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>

darnautov added 8 commits September 14, 2021 11:39

[ML] init public code

b7a5e78

[ML] init transform rule type from the monitoring plugin

22764b1

[ML] add UI form

5528e11

[ML] only suggest continuous transforms

4e893cd

[ML] executor code for transform state check

01d4681

[ML] update type

ae1f4b4

[ML] add description

90b0057

[ML] rename state prop

804e98c

darnautov added :ml v8.0.0 Feature:Transforms Transforms release_note:feature Makes this part of the condensed release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 15, 2021

darnautov requested review from peteharverson, qn895 and szabosteve September 15, 2021 14:01

darnautov self-assigned this Sep 15, 2021

darnautov added 2 commits September 15, 2021 16:26

[ML] rename state prop

fea3b9f

[ML] update test assertion

4d38af1

peteharverson reviewed Sep 15, 2021

View reviewed changes

[ML] fix import

e99df63

peteharverson reviewed Sep 16, 2021

View reviewed changes

...ugins/transform/public/alerting/transform_health_rule_type/register_transform_health_rule.ts Outdated Show resolved Hide resolved

peteharverson reviewed Sep 16, 2021

View reviewed changes

...ugins/transform/public/alerting/transform_health_rule_type/register_transform_health_rule.ts Show resolved Hide resolved

peteharverson reviewed Sep 16, 2021

View reviewed changes

...plugins/transform/server/lib/alerting/transform_health_rule_type/transform_health_service.ts Show resolved Hide resolved

darnautov added 5 commits September 16, 2021 13:30

[ML] fix i18 ids

6c27a24

[ML] update description

25e205d

[ML] validation for Included transforms

9b45e6b

[ML] fix exclude condtition

4a66cd5

[ML] remove transform rule from the monitoring rules

7143506

darnautov added 2 commits September 23, 2021 13:03

Merge remote-tracking branch 'upstream/master' into transform-111945-…

5f15ad1

…health-alerting-rule

Merge remote-tracking branch 'upstream/master' into transform-111945-…

422777a

…health-alerting-rule

darnautov requested a review from lcawl October 4, 2021 11:58

darnautov added 2 commits October 4, 2021 15:12

[ML] fix eslint

76ef141

[ML] fix eslint

a4f2e28

matschaffer reviewed Oct 5, 2021

View reviewed changes

[ML] api integration tests for transform alerting rule

af04cc9

darnautov requested a review from a team as a code owner October 5, 2021 12:37

Merge branch 'master' into transform-111945-health-alerting-rule

621f45a

YulNaumenko reviewed Oct 5, 2021

View reviewed changes

YulNaumenko reviewed Oct 6, 2021

View reviewed changes

darnautov added 3 commits October 6, 2021 13:47

[ML] move transform alert setup, set Stack Rules as a producer

a6d8fe6

[ML] remove stack_alerts project ref

c363b2c

[ML] update mappings

de0a7d9

darnautov requested a review from a team as a code owner October 6, 2021 12:56

darnautov requested a review from YulNaumenko October 6, 2021 12:59

[ML] update mappings

0d5253c

YulNaumenko approved these changes Oct 6, 2021

View reviewed changes

[ML] update unit tests

4cbd7d2

darnautov merged commit 6da1323 into elastic:master Oct 6, 2021

darnautov deleted the transform-111945-health-alerting-rule branch October 6, 2021 16:27

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021

[Transform] Transforms health alerting rule type (elastic#112277)

f56d904

kibanamachine mentioned this pull request Oct 6, 2021

[7.x] [Transform] Transforms health alerting rule type (#112277) #114142

Merged

kibanamachine added a commit that referenced this pull request Oct 6, 2021

[Transform] Transforms health alerting rule type (#112277) (#114142)

2875113

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>

This was referenced Oct 7, 2021

[ML] Increase Test Coverage 7.16 #110949

Closed

[Transform] Alerting rule type for Transform health monitoring #111945

Closed

Conversation

darnautov commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matschaffer left a comment

Choose a reason for hiding this comment

Uh oh!

matschaffer Oct 5, 2021

Choose a reason for hiding this comment

Uh oh!

darnautov Oct 5, 2021

Choose a reason for hiding this comment

Uh oh!

darnautov commented Oct 5, 2021

Uh oh!

YulNaumenko Oct 5, 2021

Choose a reason for hiding this comment

Uh oh!

darnautov Oct 6, 2021

Choose a reason for hiding this comment

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

darnautov commented Oct 6, 2021

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 6, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

History

Uh oh!

kibanamachine commented Oct 6, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

darnautov commented Sep 15, 2021 •

edited

Loading