[Security Solution] New Add Data Page#112142
Merged
kevinlog merged 52 commits intoelastic:masterfrom Oct 6, 2021
Merged
Conversation
…data_card/elastic_beats_card.tsx
…ta-screen [Security Solution] Fix tests for new data screen and update index check
…to remove add data screen
Contributor
Author
|
@elasticmachine merge upstream |
…log/kibana into task/fix-tests-for-add-data-screen
kevinlog
changed the title
2 tasks
Contributor
Author
|
@elasticmachine merge upstream |
…log/kibana into task/fix-tests-for-add-data-screen
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
stephmilovic
approved these changes
Oct 6, 2021
Contributor
stephmilovic
left a comment
stephmilovic
left a comment
There was a problem hiding this comment.
thanks for the thorough checks of indicesExist. LGTM!
kevinlog
added
the
auto-backport
Dosant
approved these changes
Oct 6, 2021
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
src/plugins/kibana_react/public/page_template/page_template.tsx data-test-subj change lgtm
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2021
* [Security Solution] New Add Data Page Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2021
* [Security Solution] New Add Data Page Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com> Co-authored-by: cchaos <caroline.horn@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In support of #107682 and pulled out of original PR #108763
Replaces the current OverviewEmpty contents with the
KibanaPageTemplate.noDataConfig.It also adds logic to the main TemplateWrapper where it checks for
indicesExistfromuseSourcererScope()to show the OverviewEmpty page over any other page contents.The links are:
learn more: https://www.elastic.co/guide/en/security/master/index.htmlAdd Elastic Agent: /app/integrations/browse?category=securityChecklist
Delete any items that are not applicable to this PR.