[eslint] add rule to forbid async subscribe bodies#112042
Closed
spalger wants to merge 14 commits intoelastic:mainfrom
Closed
[eslint] add rule to forbid async subscribe bodies#112042spalger wants to merge 14 commits intoelastic:mainfrom
spalger wants to merge 14 commits intoelastic:mainfrom
Conversation
Contributor
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Jest Integration Tests.src/cli/serve/integration_tests.cli invalid config support exits with statusCode 64 and logs a single line when config is invalidStandard OutStack TraceKibana Pipeline / jest / Jest Tests.src/core/server/elasticsearch.#stop stops pollEsNodeVersions even if there are active subscriptionsStandard OutStack TraceMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, based on #111637