Skip to content

[Maps] Fix saved object (map) switching issue #112001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kindsun merged 10 commits into from
Sep 15, 2021
Merged

[Maps] Fix saved object (map) switching issue #112001

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
56acf1a
Create new map on saved object id change
Sep 10, 2021
efcbeb5
Break start and stop ops into separate methods. Call on saved obj change
Sep 13, 2021
be94980
Merge remote-tracking branch 'upstream/master' into fix-issue-switchi…
Sep 13, 2021
5bce44a
Reset initialized to false before render
Sep 13, 2021
6f53811
Clean up
Sep 13, 2021
4e0154b
Return false from hasUnsavedChanges if no attributes
Sep 13, 2021
34226b3
Add map initialized check
Sep 14, 2021
12dbf8c
Clean up
Sep 14, 2021
e1b8dce
Review feedback. Rollback changes and add key to MapPage
Sep 15, 2021
62b8d65
Merge remote-tracking branch 'upstream/master' into fix-issue-switchi…
Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/plugins/maps/public/render_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export async function renderApp(
setHeaderActionMenu={setHeaderActionMenu}
stateTransfer={stateTransfer}
originatingApp={originatingApp}
key={routeProps.match.params.savedMapId ? routeProps.match.params.savedMapId : 'new'}
/>
);
}
Expand Down