[Alerting] Telemetry for calling legacy routes#111885
Merged
chrisronline merged 6 commits intoelastic:masterfrom Sep 13, 2021
Merged
[Alerting] Telemetry for calling legacy routes#111885chrisronline merged 6 commits intoelastic:masterfrom
chrisronline merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
ymao1
approved these changes
Sep 13, 2021
Contributor
ymao1
left a comment
There was a problem hiding this comment.
LGTM! Just some nits about the naming.
Contributor
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Sep 13, 2021
* Telemetry for calling legacy routes * Fix types * Use different counter type * PR feedback * Fix this test too # Conflicts: # x-pack/plugins/alerting/server/routes/legacy/create.ts
chrisronline
added a commit
that referenced
this pull request
Sep 13, 2021
* [Alerting] Telemetry for calling legacy routes (#111885) * Telemetry for calling legacy routes * Fix types * Use different counter type * PR feedback * Fix this test too # Conflicts: # x-pack/plugins/alerting/server/routes/legacy/create.ts * Fix missing arg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #111894
This PR introduces usage counter telemetry for legacy alerting HTTP routes.
I synced with @Bamieh and he mentioned this is a good use for usage counters. I'd imagine we have some existing dashboards already charting these data points, but if not, easy to add.
@Bamieh also mentioned we should add a consistent
counter_typeto perform group aggregations across all data points, so I added it and it's set tolegacy_api_usagefor now. This isn't used anywhere else, but we could prefixalerting_to ensure we don't conflict in the future if we want.To test, visit any legacy alerting HTTP url and then check telemetry stats (via https://localhost:5601/api/stats?extended):