Skip to content

[Obs] Show new "no data screen" on the getting started page#111803

Merged
cauemarcondes merged 6 commits intoelastic:masterfrom
cauemarcondes:obs-new-no-data-screen
Sep 13, 2021
Merged

[Obs] Show new "no data screen" on the getting started page#111803
cauemarcondes merged 6 commits intoelastic:masterfrom
cauemarcondes:obs-new-no-data-screen

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes commented Sep 9, 2021 •
edited
Loading

closes #111789

FYI: We don't need to add the "hasData" logic here since this page is only opened when there is no data available, which is checked here https://github.com/elastic/kibana/blob/master/x-pack/plugins/observability/public/pages/home/index.tsx#L17-L23

Screen Shot 2021-09-09 at 16 14 03

Observability overview page:
Screen Shot 2021-09-10 at 15 01 49

Overview page when has data
Screen Shot 2021-09-10 at 15 05 45

@cauemarcondes cauemarcondes added release_note:enhancement auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 9, 2021
@cauemarcondes cauemarcondes mentioned this pull request Sep 9, 2021
Merged
20 tasks
formgeist
formgeist approved these changes Sep 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - since there's no delay, the page template elements will load for a second before showing the empty state. I think this can be resolved by updating the page template to use the shared loading state #101356 so we won't show the side bar navigation etc. before determining whether there's data to show.

@cauemarcondes
Copy link
Copy Markdown
Contributor Author

cauemarcondes commented Sep 10, 2021

@formgeist are you okay by removing the old getting started page in favor of this one?

@formgeist
Copy link
Copy Markdown
Contributor

formgeist commented Sep 10, 2021

@formgeist are you okay by removing the old getting started page in favor of this one?

Yes, it'll be consistent throughout Kibana 👍

@cauemarcondes
Copy link
Copy Markdown
Contributor Author

cauemarcondes commented Sep 10, 2021

@formgeist are you okay by removing the old getting started page in favor of this one?

Yes, it'll be consistent throughout Kibana 👍

Cool, I'm adding it to the Overview page as well.

@cauemarcondes
Copy link
Copy Markdown
Contributor Author

cauemarcondes commented Sep 10, 2021

I also removed the side nav that was showing while fetching data.

sorenlouv
sorenlouv approved these changes Sep 12, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cauemarcondes
Copy link
Copy Markdown
Contributor Author

cauemarcondes commented Sep 13, 2021

@elasticmachine merge upstream

@cauemarcondes cauemarcondes enabled auto-merge (squash) September 13, 2021 14:24
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 13, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 342 341 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 555.8KB 550.2KB -5.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 3b4d99b into elastic:master Sep 13, 2021
@cauemarcondes cauemarcondes deleted the obs-new-no-data-screen branch September 13, 2021 15:46
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 13, 2021
@cauemarcondes @kibanamachine
[Obs] Show new "no data screen" on the getting started page (elastic#…
fca646a 
…111803)

* adding new no data screen

* adding no data screen on observability page

* fixing i18n

* i18n

* fixing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 13, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 13, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 13, 2021
@kibanamachine @cauemarcondes
[Obs] Show new "no data screen" on the getting started page (#111803) (…
4d964c4 
…#111975)

* adding new no data screen

* adding no data screen on observability page

* fixing i18n

* i18n

* fixing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
@timroes timroes removed the Feature:Home Kibana home application label Oct 27, 2021
@KOTungseth KOTungseth added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Nov 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 19, 2021

Pinging @elastic/apm-ui (Team:apm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@formgeist formgeist formgeist approved these changes

@cchaos cchaos Awaiting requested review from cchaos

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Observability Home release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Observability] New no data screen

7 participants

@cauemarcondes @formgeist @kibanamachine @elasticmachine @sorenlouv @timroes @KOTungseth