[Canvas] Adds Save and Return Workflow#111411
Merged
cqliu1 merged 1 commit intoelastic:canvas/by-value-embeddablesfrom Oct 19, 2021
Merged
[Canvas] Adds Save and Return Workflow#111411cqliu1 merged 1 commit intoelastic:canvas/by-value-embeddablesfrom
cqliu1 merged 1 commit intoelastic:canvas/by-value-embeddablesfrom
Conversation
15 tasks
531e499 to
57720fc
Compare
35728ac to
5a8361d
Compare
13 tasks
2657a68 to
40dd372
Compare
40dd372 to
02ac36e
Compare
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
e669879 to
ddb8632
Compare
92d2b5e to
49e479e
Compare
ddb8632 to
b706dfd
Compare
49e479e to
f744dd6
Compare
Contributor
|
Removing core & telemetry as reviewers as (I think) this was unintentional |
Contributor
|
When editing a Lens, and doing a "Save and Return" it's kicking me to the Canvas home listing instead of back to the workpad. (Or it's hitting a url that's invald and kicking it back there, not sure) |
55cefdc to
ca60143
Compare
9 tasks
2030a15 to
afea023
Compare
ca60143 to
ac62a31
Compare
afea023 to
6b2bc48
Compare
652f1f8 to
cb6749a
Compare
6b2bc48 to
196b94d
Compare
Updates existing embeddable with updates on edit Select incoming embeddable element on load Fixed ts errors Added use incoming embeddable hook Fixed eslint errors Added comment Fixed typo Fixed story Fix ts errors Fixed failing tests Fixed ts errors Add addUpdater to pluginServiceRegistry.start Fixed plugin appUpdater
cb6749a to
cfa5593
Compare
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/jobs/categorization_field_examples·ts.apis Machine Learning jobs Categorization example endpoint - invalid, too many tokens.Standard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
11 tasks
cqliu1
added a commit
that referenced
this pull request
Oct 19, 2021
cqliu1
added a commit
that referenced
this pull request
Oct 20, 2021
cqliu1
added a commit
that referenced
this pull request
Oct 25, 2021
cqliu1
added a commit
that referenced
this pull request
Oct 25, 2021
cqliu1
added a commit
that referenced
this pull request
Oct 26, 2021
cqliu1
added a commit
that referenced
this pull request
Oct 27, 2021
* [Canvas] Generic embeddable function (#104499) * Created generic embeddable function Fixed telemetry Updates expression on input change Fixed ts errors Store embeddable input to expression Added lib functions Added comments Fixed type errors Fixed ts errors Clean up Removed extraneous import Added context type to embeddable function def Fix import Update encode/decode fns Moved embeddable data url lib file Added embeddable test Updated comment * Fix reference extract/inject in embeddable fn * Simplify embeddable toExpression * Moved labsService to flyout.tsx * Added comment * [Canvas] Adds Save and Return Workflow (#111411) * [Canvas] Adds editor menu to Canvas (#113194) * Merge existing embeddable input with incoming embeddable input (#116026) * [Canvas] Extract and inject references for by-value embeddables (#115124) * Extract/inject references for by-value embeddables in embeddable function Fixed server interpreter setup Register external functions in canvas_plugin_src plugin def * Fixed ref name in embeddable.inject * Fixed ts errors * Fix missing type error Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cqliu1
added a commit
that referenced
this pull request
Oct 28, 2021
cqliu1
added a commit
that referenced
this pull request
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #108439.
Related to #81812.
Blocked by #104499.This introduces the save and return flow for creating new by-value embeddables in Canvas and adds support for rendering by-value embeddables in the embeddable renderer.
Note: The Lens option in the
Add elementmenu was only added temporarily for test. It'll be removed in a future PR that introduces a new menu for create new non-native visualizations in Canvas.Known issues to be addressed in future PRs
editing an embeddable and returning will add a new element instead of updating the existing onefixedOutstanding bugs (will be addressed in separate PRs)
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers