Skip to content

[7.x] [Event log][7.x] Updated event log client to search across legacy IDs (#109365)#111176

Closed
YulNaumenko wants to merge 3 commits intoelastic:7.xfrom
YulNaumenko:backport/7.x/pr-109365
Closed

[7.x] [Event log][7.x] Updated event log client to search across legacy IDs (#109365)#111176
YulNaumenko wants to merge 3 commits intoelastic:7.xfrom
YulNaumenko:backport/7.x/pr-109365

Conversation

@YulNaumenko
Copy link
Contributor

Backports the following commits to 7.x:

…elastic#109365)

* [Event log][7.x] Updated event log client to search across legacy IDs

* fixed tests

* extended kibana null version check

* added logic to alerting plugin

* fixed typechecks

* fixed typechecks

* Revert "fixed typechecks"

This reverts commit 6f6770f.

* removed legacyId for routes

* fixed typechecks

* fixed position

* fixed query

* fixed query

* fixed tests

* fixed types place

* fixed due to comments

* fixed due to comments

* fixed eslint

* fixed due to comments

* splitted test data

* fixed test data

* increased the delay time to await the search

* removed version for 7.9 docs

* Update x-pack/plugins/event_log/server/es/cluster_client_adapter.ts

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>

* fixed unit test

* fixed test data

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
@YulNaumenko YulNaumenko added the backport This PR is a backport of another PR label Sep 3, 2021
@YulNaumenko YulNaumenko enabled auto-merge (squash) September 3, 2021 16:01
@YulNaumenko
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 7, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/event_log/server/es.queryEventsBySavedObject should call cluster with proper arguments with non-default namespace

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: Invalid Version: undefined
    at new SemVer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/classes/semver.js:22:13)
    at compare (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/functions/compare.js:3:3)
    at Object.gte (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/functions/gte.js:2:30)
    at ClusterClientAdapter.queryEventsBySavedObjects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/event_log/server/es/cluster_client_adapter.ts:289:16)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/event_log/server/es/cluster_client_adapter.test.ts:341:5)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/event_log/server/es.queryEventsBySavedObject should call cluster with proper arguments with default namespace

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: Invalid Version: undefined
    at new SemVer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/classes/semver.js:22:13)
    at compare (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/functions/compare.js:3:3)
    at Object.gte (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/functions/gte.js:2:30)
    at ClusterClientAdapter.queryEventsBySavedObjects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/event_log/server/es/cluster_client_adapter.ts:289:16)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/event_log/server/es/cluster_client_adapter.test.ts:553:5)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/event_log/server/es.queryEventsBySavedObject should call cluster with sort

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

TypeError: Invalid Version: undefined
    at new SemVer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/classes/semver.js:22:13)
    at compare (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/functions/compare.js:3:3)
    at Object.gte (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/functions/gte.js:2:30)
    at ClusterClientAdapter.queryEventsBySavedObjects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/event_log/server/es/cluster_client_adapter.ts:289:16)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/event_log/server/es/cluster_client_adapter.test.ts:672:5)

and 4 more failures, only showing the first 3.

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko
Copy link
Contributor Author

Decided not to backport this changes to 7.x

auto-merge was automatically disabled September 15, 2021 14:50

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants