Skip to content

[7.14] [eslint] prevent async Promise constructor mistakes (#110349)#110731

Merged
spalger merged 7 commits intoelastic:7.14from
spalger:backport/7.14/pr-110349
Sep 1, 2021
Merged

[7.14] [eslint] prevent async Promise constructor mistakes (#110349)#110731
spalger merged 7 commits intoelastic:7.14from
spalger:backport/7.14/pr-110349

Conversation

@spalger
Copy link
Contributor

@spalger spalger commented Aug 31, 2021

Backports the following commits to 7.14:

Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	src/plugins/charts/public/services/active_cursor/use_active_cursor.test.ts
#	x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/import_rules_route.ts
#	x-pack/plugins/task_manager/server/task_scheduling.ts
@spalger spalger added the backport This PR is a backport of another PR label Aug 31, 2021
@spalger spalger enabled auto-merge (squash) August 31, 2021 22:05
@spalger
Copy link
Contributor Author

spalger commented Sep 1, 2021

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Sep 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 1.3MB 1.3MB +80.0B
ml 5.9MB 5.9MB +300.0B
visTypeTable 102.4KB 102.4KB +32.0B
visTypeVislib 564.7KB 564.8KB +40.0B
total +452.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 15.8KB 15.8KB +40.0B
fileUpload 23.2KB 23.3KB +40.0B
maps 64.5KB 64.5KB +40.0B
mapsEms 10.6KB 10.7KB +40.0B
mapsLegacy 62.9KB 63.0KB +40.0B
total +200.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 825592b into elastic:7.14 Sep 1, 2021
@spalger spalger deleted the backport/7.14/pr-110349 branch February 2, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants