Skip to content

[7.15] [RAC][Rule Registry] Put index upgrade logic under a feature flag (#110592)#110657

Merged
kibanamachine merged 1 commit intoelastic:7.15from
kibanamachine:backport/7.15/pr-110592
Aug 31, 2021
Merged

[7.15] [RAC][Rule Registry] Put index upgrade logic under a feature flag (#110592)#110657
kibanamachine merged 1 commit intoelastic:7.15from
kibanamachine:backport/7.15/pr-110592

Conversation

@kibanamachine
Copy link
Contributor

Backports the following commits to 7.15:

…astic#110592)

**Ticket:** elastic#110594

## Summary

This PR adds a feature flag around the logic that finds existing Alerts as Data indices and upgrades the mappings or rolls the index if the mappings can't be upgraded in place.

**IMPORTANT:**

- **The feature flag is switched off by default**. This is intentional, because we need to **disable the upgrade logic in 7.15.0**.
- **This is a temporary measure**. We're going to work on fixing the index upgrade logic asap and ship it before the next release that makes any mapping changes, possibly as soon as 7.15.1.
- Developers will need to enable it in their local kibana configs this way:

    ```yaml
    xpack.ruleRegistry.unsafe.indexUpgrade.enabled: true
    ```

Please check the ticket for the background of this fix.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/master/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Aug 31, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) August 31, 2021 15:43
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@kibanamachine kibanamachine merged commit 7aeaaf7 into elastic:7.15 Aug 31, 2021
@banderror banderror linked an issue Aug 31, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RAC][Rule Registry] Put index upgrade logic under a feature flag

2 participants