Skip to content

[7.x] [RAC] EuiDataGrid pagination (#109269)#110471

Merged
semd merged 1 commit intoelastic:7.xfrom
semd:backport/7.x/pr-109269
Aug 30, 2021
Merged

[7.x] [RAC] EuiDataGrid pagination (#109269)#110471
semd merged 1 commit intoelastic:7.xfrom
semd:backport/7.x/pr-109269

Conversation

@semd
Copy link
Contributor

@semd semd commented Aug 30, 2021

Backports the following commits to 7.x:

* Update T-Grid to use DataGrid pagination

* It also improves the Gtid loading state
* DataGrid pagination makes sure that we display the grid with the proper height.

* Add DataGrid height hack to t-grid

HUGE HACK!!!

DataGrtid height isn't properly calculated when the grid has horizontal scroll.
elastic/eui#5030

In order to get around this bug we are calculating `DataGrid` height here and setting it as a prop.

Please revert this commit  and allow DataGrid to calculate its height when the bug is fixed.

* Apply DataGrid laoding and pagination changes to observability

* Fix cypress tests

* Fix t-grid page render bug on Observability

* some pagination fixes

* hide table when analyzer active

* isolate exported function

Co-authored-by: semd <sergi.massaneda@elastic.co>
@semd semd force-pushed the backport/7.x/pr-109269 branch from 380b4de to 099b6af Compare August 30, 2021 13:11
@semd semd added the backport This PR is a backport of another PR label Aug 30, 2021
@semd semd enabled auto-merge (squash) August 30, 2021 13:11
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / "before all" hook for "should not allow user with read only privileges to attach alerts to cases".Alerts timeline Privileges: read only "before all" hook for "should not allow user with read only privileges to attach alerts to cases"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Error: Timed out while retrying, last result was: {false}

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Alerts timeline`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Context.completeOrRetry (http://localhost:6121/__cypress/tests?p=cypress/support/index.js:380:13)

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
timelines 843 845 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 554.8KB 554.9KB +141.0B
securitySolution 6.5MB 6.5MB +885.0B
timelines 426.8KB 419.2KB -7.6KB
total -6.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 307.4KB 307.9KB +496.0B
Unknown metric groups

API count

id before after diff
timelines 963 966 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@semd semd merged commit 027f48a into elastic:7.x Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants