Skip to content

[Alerting][8.0] Prepare alerting SOs to sharecapable#110386

Merged
YulNaumenko merged 12 commits into
masterfrom
prepare-alerting-so-to-sharecapable
Aug 31, 2021
Merged

[Alerting][8.0] Prepare alerting SOs to sharecapable#110386
YulNaumenko merged 12 commits into
masterfrom
prepare-alerting-so-to-sharecapable

Conversation

@YulNaumenko
Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko commented Aug 27, 2021 •
edited
Loading

Summary

Current PR is a merge of multiple PRs (reviewed)
#109990
#109756
#109180

and resolves next issues: #107084, #107083, #108084

Checklist

  1. Changed all saved objects created by the alerting plugin to use namespaceType: 'multiple-isolated'
  2. Added rules no-op ESO migration for 8.0
  3. Changed all SOs created by the actions plugin to use namespaceType: 'multiple-isolated'
  4. Added actions no-op ESO migration for 8.0
  5. Migrated alerting task types which contains alertId params from a legacy ID to a migrated saved object ID using this newly added API.
  6. Migrated action task types, which contains an actionTaskParamsId params from a legacy ID to a migrated saved object.

YulNaumenko and others added 3 commits August 26, 2021 15:27
@YulNaumenko @kibanamachine
[Alerting] [8.0] Prepare for making alerting saved objects sharecapab…
382a5f1 
…le (#109990)

* [Alerting] [8.0] Prepare for making alerting saved objects sharecapable

* removed v8 check

* removed link

* added no op migration

* fixed name

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@YulNaumenko
[Actions] [8.0] Prepare for making action saved objects sharecapable. (…
2e28730 
…#109756)

* [Actions] [8.0] Prepare for making action saved objects sharecapable.

* added more tests

* made it compatible to merge to 7.x

* fixed due to comments

* fixed tests

* added tests

* fixed tests

* fixed due to comments

* added no-opactions migration

* fixed test
@YulNaumenko @kibanamachine
[Task Manager][8.0] Added migrations to savedObject Ids for "actions:…
6973f69 
…* and "alerting:*" task types (#109180)

* [Task Manager][8.0] Added migrations to savedObject Ids for "actions:* and "alerting:*" task types

* fixed due to comments

* fixed typo

* added more tests

* added unit test

* added func test

* added func tests

* fixed test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@YulNaumenko YulNaumenko self-assigned this Aug 27, 2021
@YulNaumenko YulNaumenko added Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 27, 2021
@YulNaumenko YulNaumenko marked this pull request as ready for review August 30, 2021 03:37
@YulNaumenko YulNaumenko requested a review from a team as a code owner August 30, 2021 03:37
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 30, 2021

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1
ymao1 approved these changes Aug 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread x-pack/test/plugin_api_integration/test_suites/task_manager/migrations.ts Outdated
Comment thread x-pack/test/plugin_api_integration/test_suites/task_manager/migrations.ts
Comment thread x-pack/plugins/actions/server/saved_objects/action_task_params_migrations.test.ts Outdated
YulNaumenko and others added 2 commits August 30, 2021 18:58
@YulNaumenko
Copy link
Copy Markdown
Contributor Author

YulNaumenko commented Aug 31, 2021

@elasticmachine merge upstream

ymao1
ymao1 reviewed Aug 31, 2021
View reviewed changes
Comment thread x-pack/test/alerting_api_integration/spaces_only/tests/alerting/create.ts Outdated
@YulNaumenko
Copy link
Copy Markdown
Contributor Author

YulNaumenko commented Aug 31, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 31, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@YulNaumenko YulNaumenko merged commit 3e15695 into master Aug 31, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 2, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 110386 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 3, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 110386 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 6, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 110386 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 8, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 110386 or prevent reminders by adding the backport:skip label.

@mikecote mikecote added the backport:skip This PR does not require backporting label Sep 8, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 8, 2021
@mbondyra mbondyra deleted the prepare-alerting-so-to-sharecapable branch September 8, 2021 14:14
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@YulNaumenko @kibanamachine
[Alerting][8.0] Prepare alerting SOs to sharecapable (elastic#110386)
d9a8c88 
* [Alerting] [8.0] Prepare for making alerting saved objects sharecapable (elastic#109990)

* [Alerting] [8.0] Prepare for making alerting saved objects sharecapable

* removed v8 check

* removed link

* added no op migration

* fixed name

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [Actions] [8.0] Prepare for making action saved objects sharecapable. (elastic#109756)

* [Actions] [8.0] Prepare for making action saved objects sharecapable.

* added more tests

* made it compatible to merge to 7.x

* fixed due to comments

* fixed tests

* added tests

* fixed tests

* fixed due to comments

* added no-opactions migration

* fixed test

* [Task Manager][8.0] Added migrations to savedObject Ids for "actions:* and "alerting:*" task types (elastic#109180)

* [Task Manager][8.0] Added migrations to savedObject Ids for "actions:* and "alerting:*" task types

* fixed due to comments

* fixed typo

* added more tests

* added unit test

* added func test

* added func tests

* fixed test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* fixed merge

* fixed legacy tests

* fixed tests

* fixed eslint

* Update migrations.ts

fixed action task

* fixed due to comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels

backport:skip This PR does not require backporting Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@YulNaumenko @elasticmachine @kibanamachine @ymao1 @mikecote