Skip to content

[7.15] [RAC][Rule Registry] Implement versioning and backing indices (#109276)#110125

Merged
kibanamachine merged 1 commit intoelastic:7.15from
kibanamachine:backport/7.15/pr-109276
Aug 25, 2021
Merged

[7.15] [RAC][Rule Registry] Implement versioning and backing indices (#109276)#110125
kibanamachine merged 1 commit intoelastic:7.15from
kibanamachine:backport/7.15/pr-109276

Conversation

@kibanamachine
Copy link
Contributor

Backports the following commits to 7.15:

…c#109276)

**Ticket:** elastic#109293

🚨 **This PR is critical for Observability 7.15** 🚨

## Summary

This PR fixes the indexing implementation in `rule_registry`. It implements the suggestions for backwards compatibility described in the ticket:

- changes the naming scheme and introduces the concept of "backing indices", so that names of the concrete ("backing") indices != names of their aliases
- adds versioning based on the current Kibana version

TODO:

- [x] Change index naming (implement the concept of backing indices)
- [x] Include Kibana version into the index template metadata
- [x] Include Kibana version into the document fields
- [x] Remove `version` from `IndexOptions` (parameters provided by solutions/plugins when initializing alerts-as-data indices)
- [x] Fix CI

### Checklist

- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Aug 25, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) August 25, 2021 17:57
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
ruleRegistry 117 118 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.4MB 4.4MB +50.0B
observability 492.2KB 492.2KB +50.0B
total +100.0B
Unknown metric groups

API count

id before after diff
ruleRegistry 140 141 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@kibanamachine kibanamachine merged commit 8c0317e into elastic:7.15 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants