[Actions] Use references in `action_task_params` saved object by ymao1 · Pull Request #108964 · elastic/kibana

ymao1 · 2021-08-17T18:17:01Z

Resolves #108082

Summary

Updates reading and writing of action_task_params saved object to store the associated actionId and any relatedSavedObjects IDs in the references array. actionId is only extracted if the action is not preconfigured.
Adds migration to update existing action_task_params to follow the same format.

To Verify

Actions (not preconfigured)

Run this branch and create a rule with actions (not preconfigured)
Use Dev Tools to inspect an action_task_params saved object. You should see that there is an entry in the references array that points to the action saved object ID, with name actionRef and type action. You should see that the relatedSavedObjects stores refs instead of ids and the SO IDs are in the references array
Verify that this rule and its actions run successfully and that the event log documents for action execution have the corrected saved object information in them.

Preconfigured Actions

Create a rule with a preconfigured action
Use Dev Tools to inspect an action_task_params saved object. You should not see an entry in the references array with name actionRef and type action. You should still see that the relatedSavedObjects stores refs instead of ids and the SO IDs are in the references array
Verify that this rule and its actions run successfully and that the event log documents for action execution have the corrected saved object information in them.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

…aved object

…aram

…ing/action-task-params-references

elasticmachine · 2021-08-19T14:26:14Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1 · 2021-08-23T12:18:01Z

@elasticmachine merge upstream

chrisronline

This looks great! I added a couple questions/nitpicks that I wanted to get your thoughts on before I officially approve it

…ing/action-task-params-references

…ub.com/ymao1/kibana into alerting/action-task-params-references

chrisronline

LGTM!

YulNaumenko

LGTM!

ymao1 · 2021-08-25T11:12:55Z

@elasticmachine merge upstream

kibanamachine · 2021-08-25T13:29:03Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #147931 succeeded 328bfef
💚 Build #147714 succeeded 9df1864
💚 Build #146943 succeeded 5f90910
💚 Build #146887 succeeded 930cdc6
💔 Build #146812 failed 5bd8ed4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

…c#108964) * Extracting saved object references before saving action_task_params saved object * Injecting saved object ids from references when reading action_task_param * Adding migration * Adding unit test for migrations * Not differentiating between preconfigured or not * Adding functional test for migration * Skip extracting action id if action is preconfigured * Only migrating action task params for non preconfigured connectors * Simplifying related saved objects * Fixing functional test * Fixing migration * Javascript is sometimes magical * Updating functional test * PR feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-08-25T13:33:27Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

… (#110056) * Extracting saved object references before saving action_task_params saved object * Injecting saved object ids from references when reading action_task_param * Adding migration * Adding unit test for migrations * Not differentiating between preconfigured or not * Adding functional test for migration * Skip extracting action id if action is preconfigured * Only migrating action task params for non preconfigured connectors * Simplifying related saved objects * Fixing functional test * Fixing migration * Javascript is sometimes magical * Updating functional test * PR feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: ymao1 <ying.mao@elastic.co>

…c#108964) * Extracting saved object references before saving action_task_params saved object * Injecting saved object ids from references when reading action_task_param * Adding migration * Adding unit test for migrations * Not differentiating between preconfigured or not * Adding functional test for migration * Skip extracting action id if action is preconfigured * Only migrating action task params for non preconfigured connectors * Simplifying related saved objects * Fixing functional test * Fixing migration * Javascript is sometimes magical * Updating functional test * PR feedback Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

ymao1 added 18 commits August 17, 2021 13:02

Extracting saved object references before saving action_task_params s…

0913844

…aved object

Injecting saved object ids from references when reading action_task_p…

7d74359

…aram

Adding migration

c46c87f

Merge branch 'master' of https://github.com/elastic/kibana into alert…

5f90789

…ing/action-task-params-references

Adding unit test for migrations

4088232

Not differentiating between preconfigured or not

e21c15b

Merge branch 'master' of https://github.com/elastic/kibana into alert…

2c8ec86

…ing/action-task-params-references

Adding functional test for migration

0ff73d0

Merge branch 'master' of https://github.com/elastic/kibana into alert…

d0783f8

…ing/action-task-params-references

Skip extracting action id if action is preconfigured

291e109

Only migrating action task params for non preconfigured connectors

e18e5d3

Simplifying related saved objects

73ccd07

Merge branch 'master' of https://github.com/elastic/kibana into alert…

6d4c6ab

…ing/action-task-params-references

Fixing functional test

5bd8ed4

Fixing migration

930cdc6

Javascript is sometimes magical

91d5577

Merge branch 'master' of https://github.com/elastic/kibana into alert…

7dee905

…ing/action-task-params-references

Updating functional test

5f90910

ymao1 self-assigned this Aug 19, 2021

ymao1 added Feature:Actions/Framework Issues related to the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.16.0 v8.0.0 labels Aug 19, 2021

ymao1 marked this pull request as ready for review August 19, 2021 14:26

ymao1 requested a review from a team as a code owner August 19, 2021 14:26

Merge branch 'master' into alerting/action-task-params-references

9df1864

chrisronline self-requested a review August 23, 2021 14:46

chrisronline reviewed Aug 23, 2021

View reviewed changes

ymao1 added 3 commits August 23, 2021 16:33

PR feedback

105e57e

Merge branch 'master' of https://github.com/elastic/kibana into alert…

8d277c6

…ing/action-task-params-references

Merge branch 'alerting/action-task-params-references' of https://gith…

328bfef

…ub.com/ymao1/kibana into alerting/action-task-params-references

ymao1 requested a review from chrisronline August 23, 2021 20:36

chrisronline approved these changes Aug 23, 2021

View reviewed changes

ymao1 mentioned this pull request Aug 24, 2021

[Actions] [8.0] Prepare for making action saved objects sharecapable. #109756

Merged

1 task

YulNaumenko self-requested a review August 24, 2021 16:28

YulNaumenko approved these changes Aug 24, 2021

View reviewed changes

ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 25, 2021

Merge branch 'master' into alerting/action-task-params-references

140d7ac

ymao1 merged commit c037e25 into elastic:master Aug 25, 2021

kibanamachine mentioned this pull request Aug 25, 2021

[7.x] [Actions] Use references in action_task_params saved object (#108964) #110056

Merged

ymao1 deleted the alerting/action-task-params-references branch August 30, 2021 11:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Actions] Use references in `action_task_params` saved object#108964

[Actions] Use references in `action_task_params` saved object#108964
ymao1 merged 23 commits into
elastic:masterfrom
ymao1:alerting/action-task-params-references

ymao1 commented Aug 17, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Aug 19, 2021

Uh oh!

ymao1 commented Aug 23, 2021

Uh oh!

chrisronline left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrisronline left a comment

Uh oh!

YulNaumenko left a comment

Uh oh!

ymao1 commented Aug 25, 2021

Uh oh!

kibanamachine commented Aug 25, 2021

Uh oh!

kibanamachine commented Aug 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ymao1 commented Aug 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

To Verify

Actions (not preconfigured)

Preconfigured Actions

Checklist

Uh oh!

elasticmachine commented Aug 19, 2021

Uh oh!

ymao1 commented Aug 23, 2021

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

ymao1 commented Aug 25, 2021

Uh oh!

kibanamachine commented Aug 25, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

kibanamachine commented Aug 25, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ymao1 commented Aug 17, 2021 •

edited

Loading