[TSVB] Markdown variables should be clickable#108844
Merged
alexwizp merged 2 commits intoelastic:masterfrom Aug 17, 2021
Merged
[TSVB] Markdown variables should be clickable#108844alexwizp merged 2 commits intoelastic:masterfrom
alexwizp merged 2 commits intoelastic:masterfrom
Conversation
alexwizp
added
:KibanaApp/fix-it-week
Feature:TSVB
stratoula
approved these changes
Aug 17, 2021
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Code LGTM, I tested it locally and now the variables are clickable. Thank you also for adding a test :)
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
alexwizp
force-pushed
the
markdown-variables
branch
from
62b6376 to
3e09359
Compare
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @alexwizp |
alexwizp
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 17, 2021
* [TSVB] Markdown variables should be clickable * fix test
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR was based on posted by @alexwizp in #101245 (comment)_
What was done
monacoeditor API instead of replacedaceeditorScreen
Screen.Recording.2021-08-17.at.12.49.28.PM.mov