[RAC] Update alert status column in alerts table#108695
Merged
Kerry350 merged 6 commits intoelastic:masterfrom Aug 18, 2021
Merged
[RAC] Update alert status column in alerts table#108695Kerry350 merged 6 commits intoelastic:masterfrom
Kerry350 merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
|
@Kerry350 LGTM! There are two minor issues:
I will create a new issue and we can fix above issues there. My PR needs to be merged so that first issue is reproducible. |
mgiota
approved these changes
Aug 17, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 18, 2021
* Update alert status in alerts table
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Contributor
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
weltenwort
pushed a commit
to weltenwort/kibana
that referenced
this pull request
Aug 20, 2021
* Update alert status in alerts table
5 tasks
kibanamachine
added a commit
that referenced
this pull request
Aug 20, 2021
weltenwort
added a commit
that referenced
this pull request
Aug 20, 2021
Contributor
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard OutStack TraceKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/security/users·js.security app users should show the default rolesStandard OutStack TraceKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard_mode/dashboard_view_mode·js.dashboard mode Dashboard View Mode Dashboard viewer "before all" hook: Create dashboard only mode user for "shows only the dashboard app link"Standard OutStack TraceMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Kerry350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR right now as it depends on #108679. We can use theALERT_STATUS_ACTIVEandALERT_STATUS_RECOVEREDconstants from there once merged. That PR will also populate the commonALERT_STATUSfield consistently.Update: We will merge this using
openandclosedfor now. As a followup to #108679 being merged this will be changed to checkactiveandrecoveredinstead.Summary
This fixes #108041.