[Observability RAC] add filter for value action#108648
[Observability RAC] add filter for value action#108648mgiota merged 26 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@katrin-freihofner Is it ok that filter out at the moment? We decided not use the FileManager and use a simple implementation at the moment. This came up after our RAC sync up discussion on Friday. I don't know if it makes sense to spend time and implement the @weltenwort What's your thoughts on this? |
|
@weltenwort There was a requirement to filter by default for the I want to call addToQuery after the useFetcher completes so that there are data to filter for. Somehow I couldn't make this work and I left it out. Any suggestions on how to do it? I don't mind leaving out this functionality either. |
|
Looks like my PR broke the reason column, it stopped being clickable. I will look into it. UPDATE |
|
@elasticmachine merge upstream |
This commit filters by default the status column 96694b9. I hardcoded the key and the value. I will refactor it now, I just wanted to push and get some early feedback. |
41705bc to
b37f722
Compare
|
@elasticmachine merge upstream |
weltenwort
left a comment
There was a problem hiding this comment.
It works as expected, thank you 👍 I left just a few questions about possible simplifications below.
x-pack/plugins/observability/public/pages/alerts/default_cell_actions.tsx
Show resolved
Hide resolved
x-pack/plugins/observability/public/pages/alerts/alerts_search_bar.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/public/pages/alerts/default_cell_actions.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Fleet Functional Tests.x-pack/test/fleet_functional/apps/home/welcome·ts.home onboarding Welcome interstitial is displayed on a fresh install with Fleet setup executedStandard OutStack TraceMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @mgiota |
weltenwort
left a comment
There was a problem hiding this comment.
Somehow I didn't submit the review, sorry for the delay. Looks good, I only left some nit-picky style comments.
* filter for value * code clean up * fix i18n tests * fix type errors * revert changes to reason field to make reason field clickable again * [RAC Observability] fix reason field * fix type issues * filter my kibana.alert. status on load (will refactor) * refactor filter for alert status on load * remove rest params * fix eslint errors * hard code alert status for now, will be fixed in another PR * move filter_for button in a separate file * fix errors * comply with kibana i18n guideines * simpler implementation for default filtering * fix syntax error * fix type errors * fix eslint errors * fix eslint errors Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
* filter for value * code clean up * fix i18n tests * fix type errors * revert changes to reason field to make reason field clickable again * [RAC Observability] fix reason field * fix type issues * filter my kibana.alert. status on load (will refactor) * refactor filter for alert status on load * remove rest params * fix eslint errors * hard code alert status for now, will be fixed in another PR * move filter_for button in a separate file * fix errors * comply with kibana i18n guideines * simpler implementation for default filtering * fix syntax error * fix type errors * fix eslint errors * fix eslint errors Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: mgiota <giota85@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* filter for value * code clean up * fix i18n tests * fix type errors * revert changes to reason field to make reason field clickable again * [RAC Observability] fix reason field * fix type issues * filter my kibana.alert. status on load (will refactor) * refactor filter for alert status on load * remove rest params * fix eslint errors * hard code alert status for now, will be fixed in another PR * move filter_for button in a separate file * fix errors * comply with kibana i18n guideines * simpler implementation for default filtering * fix syntax error * fix type errors * fix eslint errors * fix eslint errors Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: mgiota <giota85@gmail.com>
Summary
Fixes #108119 and
Fixes #108177.
When user hovers on a cell, a plus icon appears. When clicked, it adds the respective field name and value to the search bar and to the urlbar and updates the table results
filter_in.mov
📝 Notes
recoveredandactive) will be part of this issue [RAC] [Observability] Update alert status in alerts table #108041 cc @Kerry350cc @katrin-freihofner