Merged
Conversation
* Integrate angular-translate globalization framework with i18n engine * Provide template for enabling translations in an AngularJS view by translating a view * Verification tool for translation keys used in angular-translate * Documentation
Bargs
force-pushed
the
jasper/backport/8766/5.x
branch
from
8955b7e to
9e05f4f
Compare
Contributor
|
jenkins, test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kibana Globalization - Phase 2
Backports PR #8766
Commit 1:
Add boilerplate plugin
Commit 2:
Load translations on the client side
Translations need to be loaded on the client side so that they can be used the
globalization frameworks like 'angular-translate'. This translations are made
available by embedding the translations in the initial HTML payload.
Commit 3:
Update translation plugin template for the change in how translations are published
Commit 4:
Add angular-translate as the Angular globalization framework
The angular-translate framework integrates with the Kibana i18n engine whereby it
consumes translations from the i18n engine and not the translations directly.
This is achieved by using a custom loader which calls the client side getTranslations()
method. This method return the translations loaded by the i18n engine during instantation
of Kibana server instance.
Commit 5:
Extract translation strings from the index pattern create page into translation file
This commit is where the strings are now localized for this page and therefore will be loaded by
the Angular globalization framework. It also associates a translation ID to each string block and
therefore enables translation of the strings into different languages. It also provides the
pattern for localizing other pages in the UI.
Commit 6:
Add Kibana translation documentation
Commit 7:
Update "translate" tag syntax
Commit 8:
Add new translation key pattern to verify task
Commit 9:
Fix syntax error in create view
Commit 10:
Update the translation verification to handle separate translation patterns
Commit 11:
Update after review
Updates after review comments: #8766 (review)
Commit 12:
Update internationalization documentation
Commit 13:
[test] call $timeout.flush() before debounce tests
Otherwise, the '$http GET' to fetch translation resources
shows up as a deferred task here.
Referenced from:
srl295@5d9959c
Original sha: 4dbf3a0
Authored by Martin Hickey martin.hickey@ie.ibm.com on 2017-02-21T11:12:18Z
Commit 14:
Update after review
Updates following review comments:
#8766 (review)
Commit 15:
Merge extract and verify translation build tasks into one task
Commit 16:
Update document after new changes for js and info string translations
Commit 17:
Update after review
Update the following review comments:
#8766 (review)
#8766 (review)
Commit 18:
Replace the translation string with the translation IDs in index create pattern view