Skip to content

[7.x] [ML] APM Latency Correlations: Field/value candidates prioritization (#107370)#108152

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-107370
Aug 11, 2021
Merged

[7.x] [ML] APM Latency Correlations: Field/value candidates prioritization (#107370)#108152
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-107370

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…lastic#107370)

- Makes sure fields defined in `FIELDS_TO_ADD_AS_CANDIDATE` and prefixed with one of `FIELD_PREFIX_TO_ADD_AS_CANDIDATE` get queried first when retrieving the `correlation` and `ks-test` value.
- Correctly consider the `includeFrozen` parameter.
- The bulk of the PR is a refactor:
  - Moves `query_*` files to `queries` directory
  - Introduces `asyncSearchServiceStateProvider` to manage the state of the async search service in isolation so that we no longer mutate individual vars or plain objects.
  - Introduces `asyncSearchServiceLogProvider` and extends the log to not only store messages but original error messages retrieved from ES too.
  - Refactors some more functions in separate files and adds unit tests.
  - Removes some deprecated code no longer needed.
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Aug 11, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) August 11, 2021 08:49
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@kibanamachine kibanamachine merged commit 7a448ae into elastic:7.x Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants