[Security Solution, Timelines] Replace more legacy elasticsearch types#108087
Merged
rylnd merged 2 commits intoelastic:masterfrom Aug 11, 2021
Merged
[Security Solution, Timelines] Replace more legacy elasticsearch types#108087rylnd merged 2 commits intoelastic:masterfrom
rylnd merged 2 commits intoelastic:masterfrom
Conversation
rylnd
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
These are both number | undefined, so we default to 0 if we need a value. Fixes the type errors resulting from the previous type changes.
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @rylnd |
kqualters-elastic
approved these changes
Aug 10, 2021
rylnd
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 11, 2021
elastic#108087) * Replace more legacy elasticsearch types * Handle possibly undefined response fields These are both number | undefined, so we default to 0 if we need a value. Fixes the type errors resulting from the previous type changes.
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
74 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to #107226, as a few more imports snuck through while this was in review.
For maintainers