[Runtime field editor] Error handling by sebelga · Pull Request #107932 · elastic/kibana

sebelga · 2021-08-09T16:33:14Z

This PR contains the error handling enhancement for the runtime field editor,

kibanamachine · 2021-08-09T16:43:00Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 6e78d73
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.src/plugins/index_pattern_field_editor/__jest__/client_integration.Field editor Preview panel empty prompt should display an empty prompt if no name and no script are defined

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: _monaco.PainlessLang.isValidating is not a function
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/index_pattern_field_editor/public/components/field_editor/form_fields/script_field.tsx:91:46
    at new Promise (<anonymous>)
    at validator (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/index_pattern_field_editor/public/components/field_editor/form_fields/script_field.tsx:89:48)
    at runSync (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:294:36)
    at runValidations (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:335:14)
    at Object.validate (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:395:32)
    at map (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_form.ts:162:47)
    at Array.map (<anonymous>)
    at __validateFields (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_form.ts:162:26)
    at onValueChange (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:143:11)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:582:5
    at commitHookEffectList (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:22030:26)
    at commitPassiveHookEffects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:22064:11)
    at HTMLUnknownElement.callCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at HTMLUnknownElement.callTheUserObjectsOperation (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
    at innerInvokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:318:25)
    at invokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
    at HTMLUnknownElementImpl._dispatch (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:221:9)
    at HTMLUnknownElementImpl.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:94:17)
    at HTMLUnknownElement.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:231:34)
    at Object.invokeGuardedCallbackDev (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at flushPassiveEffectsImpl (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:25392:7)
    at unstable_runWithPriority (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at runWithPriority$2 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:12149:10)
    at flushPassiveEffects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:25361:12)
    at Object.<anonymous>.flushWork (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1041:10)
    at flushWorkAndMicroTasks (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1050:5)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1130:11

Kibana Pipeline / jest / Jest Tests.src/plugins/index_pattern_field_editor/__jest__/client_integration.Field editor Preview panel key & value should set the value returned by the painless _execute API

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: _monaco.PainlessLang.isValidating is not a function
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/index_pattern_field_editor/public/components/field_editor/form_fields/script_field.tsx:91:46
    at new Promise (<anonymous>)
    at validator (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/index_pattern_field_editor/public/components/field_editor/form_fields/script_field.tsx:89:48)
    at runSync (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:294:36)
    at runValidations (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:335:14)
    at Object.validate (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:395:32)
    at map (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_form.ts:162:47)
    at Array.map (<anonymous>)
    at __validateFields (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_form.ts:162:26)
    at onValueChange (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:143:11)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:582:5
    at commitHookEffectList (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:22030:26)
    at commitPassiveHookEffects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:22064:11)
    at HTMLUnknownElement.callCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at HTMLUnknownElement.callTheUserObjectsOperation (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
    at innerInvokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:318:25)
    at invokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
    at HTMLUnknownElementImpl._dispatch (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:221:9)
    at HTMLUnknownElementImpl.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:94:17)
    at HTMLUnknownElement.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:231:34)
    at Object.invokeGuardedCallbackDev (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at flushPassiveEffectsImpl (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:25392:7)
    at unstable_runWithPriority (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at runWithPriority$2 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:12149:10)
    at flushPassiveEffects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:25361:12)
    at Object.<anonymous>.flushWork (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1041:10)
    at flushWorkAndMicroTasks (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1050:5)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1130:11

Kibana Pipeline / jest / Jest Tests.src/plugins/index_pattern_field_editor/__jest__/client_integration.Field editor Preview panel key & value should display an updating indicator while fetching the preview

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: _monaco.PainlessLang.isValidating is not a function
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/index_pattern_field_editor/public/components/field_editor/form_fields/script_field.tsx:91:46
    at new Promise (<anonymous>)
    at validator (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/index_pattern_field_editor/public/components/field_editor/form_fields/script_field.tsx:89:48)
    at runSync (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:294:36)
    at runValidations (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:335:14)
    at Object.validate (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:395:32)
    at map (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_form.ts:162:47)
    at Array.map (<anonymous>)
    at __validateFields (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_form.ts:162:26)
    at onValueChange (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:143:11)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/es_ui_shared/static/forms/hook_form_lib/hooks/use_field.ts:582:5
    at commitHookEffectList (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:22030:26)
    at commitPassiveHookEffects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:22064:11)
    at HTMLUnknownElement.callCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at HTMLUnknownElement.callTheUserObjectsOperation (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
    at innerInvokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:318:25)
    at invokeEventListeners (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
    at HTMLUnknownElementImpl._dispatch (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:221:9)
    at HTMLUnknownElementImpl.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:94:17)
    at HTMLUnknownElement.dispatchEvent (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:231:34)
    at Object.invokeGuardedCallbackDev (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at flushPassiveEffectsImpl (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:25392:7)
    at unstable_runWithPriority (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at runWithPriority$2 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:12149:10)
    at flushPassiveEffects (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:25361:12)
    at Object.<anonymous>.flushWork (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1041:10)
    at flushWorkAndMicroTasks (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1050:5)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1130:11

and 12 more failures, only showing the first 3.

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sebelga · 2021-08-19T11:44:01Z

Closed in favour of #109233

sebelga added 2 commits August 9, 2021 18:27

Add observable to Painless lang model to know when it is validating

8d8d870

Update script field validation to use Observable instead of setTimeout

6e78d73

alisonelizabeth deleted the branch elastic:runtime-field-editor/preview-field-workstream August 13, 2021 22:27

alisonelizabeth closed this Aug 13, 2021

sebelga deleted the runtime-field-editor/error-handling branch August 19, 2021 11:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Runtime field editor] Error handling#107932

[Runtime field editor] Error handling#107932
sebelga wants to merge 2 commits intoelastic:runtime-field-editor/preview-field-workstreamfrom
sebelga:runtime-field-editor/error-handling

sebelga commented Aug 9, 2021

Uh oh!

kibanamachine commented Aug 9, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

sebelga commented Aug 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sebelga commented Aug 9, 2021

Uh oh!

kibanamachine commented Aug 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

sebelga commented Aug 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kibanamachine commented Aug 9, 2021 •

edited

Loading