[build_ts_refs] automatically update tsconfig.refs.json#107804
[build_ts_refs] automatically update tsconfig.refs.json#107804spalger wants to merge 4 commits intoelastic:masterfrom
Conversation
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
| let I18nContext: I18nStart['Context'] | undefined; | ||
| let isLoaded = false; |
There was a problem hiding this comment.
These changes were necessary because this project wasn't being built in the composite build previously and private properties on class expressions aren't compatible. Functionality is the same but avoid the type errors
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
I tested warnings (node scripts/build_ts_refs.js --validate-root-refs-config) and writes (node scripts/build_ts_refs.js)
LGTM
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Handled by #107981 |
4 participants
While debugging some issues with @kime I noticed that a project wasn't in the
tsconfig.refs.jsondirectory. This prevents the ts_build_refs script from knowing it is built by TS, and could lead to some of the caching inconsistencies we've been seeing. To prevent this from being an issue I think we should automatically generate that root refs config file using the full TS projects list we have and use for type checking all the different ts projects. This collection of projects is exhaustive and every TS file in the repo is validated to belong to exactly one project.