[Security Solution][RAC] - Replace hard coded indices by michaelolo24 · Pull Request #107564 · elastic/kibana

michaelolo24 · 2021-08-03T17:06:26Z

Summary

This PR is just updating the indices to keep the UI in sync with the new indices here: https://github.com/elastic/kibana/pull/105096/files and https://github.com/elastic/kibana/pull/106049/files

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

…076ca54526ea0e61a9a99e1c1bce854806977e

…t tests

…-type

…nd daterange tuple

…-type

kibanamachine · 2021-08-03T17:31:44Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 033379c
Storybooks Preview
This comment will update when the build is complete

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/public/common/components/drag_and_drop.helpers #allowTopN it returns true for a allowlisted non-BrowserField

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/public/common/components/drag_and_drop/helpers.test.ts:668:9)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/public/common/components/events_viewer.StatefulEventsViewer it renders the events viewer

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `StatefulEventsViewer it renders the events viewer 1`

Snapshot: "Showing: 12 events1 fields sorted@timestamp1event.severityevent.categoryevent.actionhost.namesource.ipdestination.ipdestination.bytesuser.name_idmessage0 of 12 events123"
Received: "hello grid"
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/public/common/components/events_viewer/index.test.tsx:65:30
    at runWithExpensiveErrorDiagnosticsDisabled (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/config.js:51:12)
    at checkCallback (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/wait-for.js:127:77)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/wait-for.js:94:7
    at new Promise (<anonymous>)
    at waitFor (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/wait-for.js:40:10)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/wait-for.js:174:54
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/react/dist/pure.js:57:22
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/react/dist/act-compat.js:61:24
    at batchedUpdates$1 (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom.development.js:24386:12)
    at act (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1092:14)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/react/dist/act-compat.js:60:20
    at new Promise (<anonymous>)
    at asyncAct (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/react/dist/act-compat.js:38:14)
    at Object.asyncWrapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/react/dist/pure.js:56:35)
    at waitForWrapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/@testing-library/dom/dist/wait-for.js:174:35)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/public/common/components/events_viewer/index.test.tsx:62:11)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

michaelolo24 · 2021-08-05T05:06:29Z

work is being completed here instead: #107713

marshallmain and others added 30 commits June 30, 2021 12:12

injects bulkCreate and wrapHits to individual rule executors

e2467ac

WIP create_security_rule_type_factory based on Marshall's work in #d3…

ae41613

…076ca54526ea0e61a9a99e1c1bce854806977e

removes ruleStatusService from old rule executors, fixes executor uni…

83a2f0f

…t tests

fixes rebase

5fd3f60

Merge branch 'master' of github.com:elastic/kibana into security-rule…

b95b6b6

…-type

Rename reference_rules to rule_types

2c0236e

Fix type errors

637246c

Fix type errors in base security rule factory

c336531

Additional improvements to types and interfaces

0645902

More type alignment

72032d7

Fix remaining type errors in query rule

7ea0928

Add validation / inject lists plugin

c92dbe6

Merge branch 'master' of github.com:elastic/kibana into security-rule…

849a428

…-type

Formatting

6fb0fc8

Improvements to typing

b302674

Static typing on executors

3cd9ee7

cleanup

44eb2de

Hook up params for query/threshold rules... includes exceptionsList a…

b4b7b56

…nd daterange tuple

Merge branch 'master' of github.com:elastic/kibana into security-rule…

14b0b6b

…-type

Scaffolding for wrapHits and bulkCreate

f9922fa

Add error handling / status reporting

78601da

Fixup alert type state

47f0f9c

Begin threshold

5450d1b

Begin work on threshold state

a6a9efc

Organize rule types

a22c321

Export base security rule types

dc4f5bf

Fixup lifecycle static typing

b8185f2

WrapHits / bulk changes

a8c0b4e

Field mappings (partial)

e25b32b

whoops

a7771bd

madirey and others added 15 commits July 29, 2021 16:06

Update more field refs

3175fed

Actually use refresh param

dcae14d

cleanup

5e3e3bb

test fixes

eb1b900

Merge branch 'master' of github.com:elastic/kibana into security-rule…

c44bd32

…-type

changes to rule creation script

d76eecd

Fix created signals count

01529fc

Use ruleId

668dddc

Updates to bulk indexing

8d19387

Mapping updates

44d0a2a

Cannot use 'strict' for dynamic setting

091b64a

Merge branch 'master' of github.com:elastic/kibana into security-rule…

7f519e8

…-type

Merge branch 'master' into security-rule-type

3ef3de9

Merge branch 'master' into security-rule-type

cfbdd20

replace indices wip

033379c

michaelolo24 added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 release_note:skip Skip the PR/issue when compiling release notes Theme: rac label obsolete v8.0.0 labels Aug 3, 2021

michaelolo24 closed this Aug 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][RAC] - Replace hard coded indices#107564

[Security Solution][RAC] - Replace hard coded indices#107564
michaelolo24 wants to merge 97 commits intoelastic:masterfrom
michaelolo24:replace-hard-coded-indices

michaelolo24 commented Aug 3, 2021

Uh oh!

kibanamachine commented Aug 3, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

michaelolo24 commented Aug 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

michaelolo24 commented Aug 3, 2021

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

kibanamachine commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

michaelolo24 commented Aug 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kibanamachine commented Aug 3, 2021 •

edited

Loading