Skip to content

Convert saved object management to json editor #106746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timroes wants to merge 1 commit into from
Closed

Convert saved object management to json editor #106746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 0 additions & 115 deletions src/plugins/saved_objects_management/public/lib/in_app_url.test.ts
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions src/plugins/saved_objects_management/public/lib/in_app_url.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/plugins/saved_objects_management/public/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

export { fetchExportByTypeAndSearch } from './fetch_export_by_type_and_search';
export { fetchExportObjects } from './fetch_export_objects';
export { canViewInApp } from './in_app_url';
export { getRelationships } from './get_relationships';
export { getSavedObjectCounts } from './get_saved_object_counts';
export { getSavedObjectLabel } from './get_saved_object_label';
Expand Down
3 changes: 1 addition & 2 deletions src/plugins/saved_objects_management/public/management_section/mount_section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,11 @@ export const mountManagementSection = async ({
<I18nProvider>
<Router history={history}>
<Switch>
<Route path={'/:service/:id'} exact={true}>
<Route path={'/:type/:id'} exact={true}>
<RedirectToHomeIfUnauthorized>
<Suspense fallback={<EuiLoadingSpinner />}>
<SavedObjectsEditionPage
coreStart={coreStart}
serviceRegistry={serviceRegistry}
setBreadcrumbs={setBreadcrumbs}
history={history}
/>
Expand Down
37 changes: 7 additions & 30 deletions ...gins/saved_objects_management/public/management_section/object_view/components/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,43 +9,22 @@
import React from 'react';
import { EuiButton, EuiPageHeader } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';

interface HeaderProps {
canEdit: boolean;
canDelete: boolean;
canViewInApp: boolean;
type: string;
viewUrl: string;
onDeleteClick: () => void;
}

const renderConditionalTitle = (canEdit: boolean, type: string) =>
canEdit ? (
<FormattedMessage
id="savedObjectsManagement.view.editItemTitle"
defaultMessage="Edit {title}"
values={{ title: type }}
/>
) : (
<FormattedMessage
id="savedObjectsManagement.view.viewItemTitle"
defaultMessage="View {title}"
values={{ title: type }}
/>
);

export const Header = ({
canEdit,
canDelete,
canViewInApp,
type,
viewUrl,
onDeleteClick,
}: HeaderProps) => {
export const Header = ({ canDelete, canViewInApp, viewUrl, onDeleteClick }: HeaderProps) => {
return (
<EuiPageHeader
bottomBorder
pageTitle={renderConditionalTitle(canEdit, type)}
pageTitle={i18n.translate('savedObjectsManagement.view.inspectTitle', {
defaultMessage: 'Inspect saved object',
})}
rightSideItems={[
canViewInApp && (
<EuiButton
Expand All @@ -56,8 +35,7 @@ export const Header = ({
>
<FormattedMessage
id="savedObjectsManagement.view.viewItemButtonLabel"
defaultMessage="View {title}"
values={{ title: type }}
defaultMessage="View in application"
/>
</EuiButton>
),
Expand All @@ -71,8 +49,7 @@ export const Header = ({
>
<FormattedMessage
id="savedObjectsManagement.view.deleteItemButtonLabel"
defaultMessage="Delete {title}"
values={{ title: type }}
defaultMessage="Delete"
/>
</EuiButton>
),
Expand Down
Loading