Skip to content

Comments

Restore legacy SAML ACS endpoint.#106665

Merged
azasypkin merged 2 commits intoelastic:masterfrom
azasypkin:issue-xxx-revert-47929
Jul 26, 2021
Merged

Restore legacy SAML ACS endpoint.#106665
azasypkin merged 2 commits intoelastic:masterfrom
azasypkin:issue-xxx-revert-47929

Conversation

@azasypkin
Copy link
Contributor

@azasypkin azasypkin commented Jul 26, 2021 •
edited
Loading

Summary

Revert of: #47929

We agreed to continue supporting old ACS routes for the time being.

Considering the nature of the change (new and old routes are almost exact copies) it seems reasonable to not write additional integration tests for the legacy route. We may reconsider this decision if the implementation diverge in the future or we discover bugs related to the old route only.

@azasypkin azasypkin added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// Feature:Security/Authentication Platform Security - Authentication v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Jul 26, 2021
@azasypkin azasypkin mentioned this pull request Jul 26, 2021
Merged
azasypkin
azasypkin commented Jul 26, 2021
View reviewed changes
@azasypkin azasypkin marked this pull request as ready for review July 26, 2021 08:36
@azasypkin azasypkin requested a review from a team as a code owner July 26, 2021 08:36
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 26, 2021

Pinging @elastic/kibana-security (Team:Security)

@azasypkin azasypkin requested a review from legrego July 26, 2021 08:36
legrego
legrego approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@legrego legrego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit - thanks!

x-pack/plugins/security/server/routes/authentication/saml.ts
},
},
async (context, request, response) => {
if (path === '/api/security/v1/saml') {
Copy link
Member

@legrego legrego Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done in followup (so that we can backport), but I think it would be good to start collecting telemetry on how many clusters are configured to use these deprecated endpoints. That will help us decide when it is safe to drop support for these routes in the future.

Copy link
Contributor Author

@azasypkin azasypkin Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a great idea!

@azasypkin @legrego
Update x-pack/plugins/security/server/routes/authentication/saml.ts
8ab78ee 
Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 26, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
actions 117 - -117
advancedSettings 22 - -22
alerting 234 - -234
apm 39 - -39
apmOss 4 - -4
banners 9 - -9
bfetch 62 - -62
canvas 5 - -5
cases 407 - -407
charts 159 - -159
cloud 21 - -21
core 1080 - -1080
dashboard 137 - -137
dashboardEnhanced 50 - -50
dashboardMode 11 - -11
data 3162 - -3162
dataEnhanced 16 - -16
dataVisualizer 104 - -104
devTools 8 - -8
discover 55 - -55
discoverEnhanced 37 - -37
embeddable 384 - -384
embeddableEnhanced 14 - -14
encryptedSavedObjects 28 - -28
enterpriseSearch 2 - -2
esUiShared 90 - -90
eventLog 70 - -70
expressionError 12 - -12
expressionRepeatImage 28 - -28
expressionRevealImage 4 - -4
expressions 1567 - -1567
expressionShape 90 - -90
features 97 - -97
fileUpload 128 - -128
fleet 1033 - -1033
globalSearch 14 - -14
home 70 - -70
indexLifecycleManagement 4 - -4
indexManagement 157 - -157
indexPatternFieldEditor 29 - -29
infra 22 - -22
inspector 78 - -78
kibanaLegacy 62 - -62
kibanaReact 230 - -230
kibanaUtils 359 - -359
lens 169 - -169
licenseApiGuard 8 - -8
licenseManagement 3 - -3
licensing 42 - -42
lists 143 - -143
management 40 - -40
maps 203 - -203
mapsEms 75 - -75
metricsEntities 6 - -6
ml 274 - -274
monitoring 10 - -10
navigation 31 - -31
newsfeed 17 - -17
observability 219 - -219
osquery 11 - -11
presentationUtil 136 - -136
remoteClusters 4 - -4
reporting 132 - -132
rollup 20 - -20
ruleRegistry 60 - -60
runtimeFields 19 - -19
savedObjects 199 - -199
savedObjectsManagement 85 - -85
savedObjectsTagging 50 - -50
savedObjectsTaggingOss 50 - -50
screenshotMode 17 - -17
security 51 - -51
securityOss 9 - -9
securitySolution 1245 - -1245
share 83 - -83
snapshotRestore 22 - -22
spacesOss 5 - -5
stackAlerts 4 - -4
taskManager 25 - -25
telemetryCollectionManager 29 - -29
telemetryCollectionXpack 1 - -1
telemetryManagementSection 13 - -13
timelines 763 - -763
triggersActionsUi 228 - -228
uiActions 88 - -88
uiActionsEnhanced 147 - -147
urlForwarding 15 - -15
usageCollection 16 - -16
visTypeTimeseries 10 - -10
visualizations 229 - -229
total -15317

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
bfetch 1 - -1
charts 2 - -2
core 148 - -148
dashboard 1 - -1
data 98 - -98
dataVisualizer 3 - -3
embeddable 4 - -4
esUiShared 4 - -4
expressions 58 - -58
fileUpload 4 - -4
fleet 15 - -15
indexManagement 12 - -12
indexPatternFieldEditor 1 - -1
inspector 6 - -6
kibanaLegacy 3 - -3
kibanaReact 5 - -5
kibanaUtils 3 - -3
maps 2 - -2
mapsEms 1 - -1
ml 10 - -10
presentationUtil 3 - -3
reporting 1 - -1
savedObjects 3 - -3
savedObjectsTaggingOss 3 - -3
securitySolution 8 - -8
share 1 - -1
snapshotRestore 1 - -1
timelines 6 - -6
triggersActionsUi 1 - -1
uiActionsEnhanced 2 - -2
visTypeTimeseries 1 - -1
visualizations 13 - -13
total -424

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
actions 7 - -7
advancedSettings 1 - -1
alerting 16 - -16
apm 30 - -30
bfetch 2 - -2
canvas 3 - -3
cases 14 - -14
charts 1 - -1
core 31 - -31
dashboard 9 - -9
data 64 - -64
dataEnhanced 2 - -2
devTools 2 - -2
discover 6 - -6
discoverEnhanced 2 - -2
embeddable 3 - -3
encryptedSavedObjects 3 - -3
esUiShared 1 - -1
eventLog 4 - -4
expressionError 2 - -2
expressionRevealImage 1 - -1
expressions 5 - -5
features 2 - -2
fileUpload 1 - -1
fleet 8 - -8
globalSearch 5 - -5
home 5 - -5
indexManagement 3 - -3
indexPatternFieldEditor 4 - -4
infra 3 - -3
inspector 4 - -4
kibanaLegacy 1 - -1
kibanaReact 4 - -4
kibanaUtils 8 - -8
lens 14 - -14
licensing 8 - -8
lists 38 - -38
management 5 - -5
maps 11 - -11
metricsEntities 1 - -1
ml 33 - -33
monitoring 2 - -2
navigation 2 - -2
observability 10 - -10
presentationUtil 5 - -5
reporting 14 - -14
ruleRegistry 9 - -9
runtimeFields 2 - -2
savedObjects 5 - -5
screenshotMode 1 - -1
security 6 - -6
securityOss 3 - -3
securitySolution 28 - -28
share 8 - -8
snapshotRestore 1 - -1
taskManager 8 - -8
telemetryCollectionManager 4 - -4
timelines 25 - -25
triggersActionsUi 19 - -19
uiActions 11 - -11
uiActionsEnhanced 10 - -10
usageCollection 2 - -2
visTypeTimeseries 3 - -3
visualizations 12 - -12
total -557
Unknown metric groups

API count

id before after diff
actions 117 - -117
advancedSettings 23 - -23
alerting 242 - -242
apm 39 - -39
apmOss 4 - -4
banners 9 - -9
bfetch 73 - -73
canvas 6 - -6
cases 445 - -445
charts 190 - -190
cloud 21 - -21
core 2359 - -2359
dashboard 160 - -160
dashboardEnhanced 51 - -51
dashboardMode 11 - -11
data 3716 - -3716
dataEnhanced 16 - -16
dataVisualizer 104 - -104
devTools 10 - -10
discover 81 - -81
discoverEnhanced 39 - -39
embeddable 456 - -456
embeddableEnhanced 14 - -14
encryptedSavedObjects 30 - -30
enterpriseSearch 2 - -2
esUiShared 92 - -92
eventLog 70 - -70
expressionError 12 - -12
expressionRepeatImage 28 - -28
expressionRevealImage 4 - -4
expressions 2003 - -2003
expressionShape 90 - -90
features 215 - -215
fileUpload 128 - -128
fleet 1128 - -1128
globalSearch 68 - -68
home 94 - -94
indexLifecycleManagement 4 - -4
indexManagement 162 - -162
indexPatternFieldEditor 31 - -31
infra 25 - -25
inspector 101 - -101
kibanaLegacy 66 - -66
kibanaReact 260 - -260
kibanaUtils 551 - -551
lens 185 - -185
licenseApiGuard 8 - -8
licenseManagement 3 - -3
licensing 117 - -117
lists 150 - -150
management 40 - -40
maps 204 - -204
mapsEms 75 - -75
metricsEntities 9 - -9
ml 278 - -278
monitoring 10 - -10
navigation 31 - -31
newsfeed 17 - -17
observability 219 - -219
osquery 11 - -11
presentationUtil 163 - -163
remoteClusters 4 - -4
reporting 133 - -133
rollup 20 - -20
ruleRegistry 60 - -60
runtimeFields 24 - -24
savedObjects 213 - -213
savedObjectsManagement 96 - -96
savedObjectsTagging 54 - -54
savedObjectsTaggingOss 89 - -89
screenshotMode 22 - -22
security 112 - -112
securityOss 12 - -12
securitySolution 1296 - -1296
share 123 - -123
snapshotRestore 23 - -23
spaces 106 - -106
spacesOss 72 - -72
stackAlerts 4 - -4
taskManager 52 - -52
telemetry 42 - -42
telemetryCollectionManager 29 - -29
telemetryCollectionXpack 1 - -1
telemetryManagementSection 14 - -14
timelines 882 - -882
triggersActionsUi 237 - -237
uiActions 127 - -127
uiActionsEnhanced 205 - -205
urlForwarding 15 - -15
usageCollection 57 - -57
visTypeTimeseries 10 - -10
visualizations 247 - -247
total -19251

References to deprecated APIs

id before after diff
actions 8 - -8
alerting 32 - -32
apm 7 - -7
canvas 53 - -53
cases 151 - -151
crossClusterReplication 2 - -2
dashboard 128 - -128
dashboardEnhanced 10 - -10
dataEnhanced 53 - -53
dataVisualizer 16 - -16
discover 102 - -102
discoverEnhanced 19 - -19
embeddable 2 - -2
encryptedSavedObjects 2 - -2
fleet 89 - -89
globalSearch 4 - -4
graph 2 - -2
indexLifecycleManagement 2 - -2
indexManagement 12 - -12
infra 292 - -292
lens 168 - -168
lists 103 - -103
maps 592 - -592
ml 140 - -140
observability 34 - -34
presentationUtil 2 - -2
savedObjects 6 - -6
savedObjectsManagement 18 - -18
savedObjectsTaggingOss 5 - -5
security 2 - -2
securitySolution 881 - -881
stackAlerts 104 - -104
timelines 76 - -76
transform 16 - -16
uptime 11 - -11
urlDrilldown 18 - -18
visTypeTimeseries 10 - -10
visualizations 32 - -32
total -3204

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin merged commit 6c8f00b into elastic:master Jul 26, 2021
@azasypkin azasypkin deleted the issue-xxx-revert-47929 branch July 26, 2021 15:42
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@azasypkin @vadimkibana
Restore legacy SAML ACS endpoint. (elastic#106665)
b097e40
@jeramysoucy jeramysoucy mentioned this pull request Nov 11, 2024
Merged
jeramysoucy added a commit that referenced this pull request Nov 19, 2024
@jeramysoucy @kibanamachine
Surface Kibana security route deprecations in Upgrade Assistant (#199656
742ae9f 
)

Closes #197389

## Summary

Uses the `deprecated` route configuration option on all Kibana Security
"v1" endpoints. This will surface deprecation information in the Upgrade
Assistant.

## Related PRs
- #50695 - `7.6.0`, deprecated
    - `/api/security/v1/me`
    - `/api/security/v1/logout`
    - `/api/security/v1/oidc/implicit`
    - `/api/security/v1/oidc` (POST)
- #53886 - `7.6.0`, deprecated
`/api/security/v1/oidc` (GET)
- #47929 - `8.0.0`, dropped
`/api/security/v1/saml` (`breaking` release note)
- #106665 - restored
`/api/security/v1/saml` but warned as deprecated (no release note)

## Testing
1.  Start ES & Kibana in trial license mode
2. Make several calls to one or more of the deprecated endpoints
3. Navigate to `Stack Management`->`Upgrade Assistant`
4. Click on Kibana warnings
<img width="1003" alt="Screenshot 2024-11-18 at 10 01 10 AM"
src="https://github.com/user-attachments/assets/da44af13-57eb-4ffd-a507-e423eb767a11">
5. Confirm the called endpoints are displayed as warnings in the Upgrade
Assistant
<img width="1274" alt="Screenshot 2024-11-18 at 9 59 34 AM"
src="https://github.com/user-attachments/assets/4c054fbe-6838-48cf-8b1b-8c161252db0f">

## Previous release notes 
### v7.6.0

https://www.elastic.co/guide/en/kibana/7.6/release-notes-7.6.0.html#deprecation-7.6.0
https://www.elastic.co/guide/en/kibana/7.6/breaking-changes-7.6.html
The deprecations are not listed in the release notes or breaking changes
notes.

### v8.0.0

https://www.elastic.co/guide/en/kibana/current/release-notes-8.0.0-alpha1.html#rest-api-changes
SAML endpoint deprecation only appears in the 8.0.0-alpha1 release
notes, and was reverted in 8.0.0-alpha2

# Release note
See `docs/upgrade-notes.asciidoc` in file changes

# Follow-up
A follow-up PR must be created to create and backfill the docLinks.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
jeramysoucy added a commit to jeramysoucy/kibana that referenced this pull request Nov 22, 2024
@jeramysoucy
Surface Kibana security route deprecations in Upgrade Assistant (elas…
83f5860 
…tic#199656)

Closes elastic#197389

## Summary

Uses the `deprecated` route configuration option on all Kibana Security
"v1" endpoints. This will surface deprecation information in the Upgrade
Assistant.

## Related PRs
- elastic#50695 - `7.6.0`, deprecated
    - `/api/security/v1/me`
    - `/api/security/v1/logout`
    - `/api/security/v1/oidc/implicit`
    - `/api/security/v1/oidc` (POST)
- elastic#53886 - `7.6.0`, deprecated
`/api/security/v1/oidc` (GET)
- elastic#47929 - `8.0.0`, dropped
`/api/security/v1/saml` (`breaking` release note)
- elastic#106665 - restored
`/api/security/v1/saml` but warned as deprecated (no release note)

## Testing
1.  Start ES & Kibana in trial license mode
2. Make several calls to one or more of the deprecated endpoints
3. Navigate to `Stack Management`->`Upgrade Assistant`
4. Click on Kibana warnings
<img width="1003" alt="Screenshot 2024-11-18 at 10 01 10 AM"
src="https://github.com/user-attachments/assets/da44af13-57eb-4ffd-a507-e423eb767a11">
5. Confirm the called endpoints are displayed as warnings in the Upgrade
Assistant
<img width="1274" alt="Screenshot 2024-11-18 at 9 59 34 AM"
src="https://github.com/user-attachments/assets/4c054fbe-6838-48cf-8b1b-8c161252db0f">

## Previous release notes
### v7.6.0

https://www.elastic.co/guide/en/kibana/7.6/release-notes-7.6.0.html#deprecation-7.6.0
https://www.elastic.co/guide/en/kibana/7.6/breaking-changes-7.6.html
The deprecations are not listed in the release notes or breaking changes
notes.

### v8.0.0

https://www.elastic.co/guide/en/kibana/current/release-notes-8.0.0-alpha1.html#rest-api-changes
SAML endpoint deprecation only appears in the 8.0.0-alpha1 release
notes, and was reverted in 8.0.0-alpha2

# Release note
See `docs/upgrade-notes.asciidoc` in file changes

# Follow-up
A follow-up PR must be created to create and backfill the docLinks.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 742ae9f)

# Conflicts:
#	docs/upgrade-notes.asciidoc
#	x-pack/plugins/security/tsconfig.json
jeramysoucy added a commit that referenced this pull request Nov 22, 2024
@jeramysoucy
[8.x] Surface Kibana security route deprecations in Upgrade Assistant (…
d783031 
…#199656) (#201320)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Surface Kibana security route deprecations in Upgrade Assistant
(#199656)](#199656)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jeramy
Soucy","email":"jeramy.soucy@elastic.co"},"sourceCommit":{"committedDate":"2024-11-19T08:54:40Z","message":"Surface
Kibana security route deprecations in Upgrade Assistant
(#199656)\n\nCloses #197389\r\n\r\n## Summary\r\n\r\nUses the
`deprecated` route configuration option on all Kibana Security\r\n\"v1\"
endpoints. This will surface deprecation information in the
Upgrade\r\nAssistant.\r\n\r\n## Related PRs\r\n-
#50695 - `7.6.0`, deprecated\r\n -
`/api/security/v1/me`\r\n - `/api/security/v1/logout`\r\n -
`/api/security/v1/oidc/implicit`\r\n - `/api/security/v1/oidc`
(POST)\r\n- #53886 - `7.6.0`,
deprecated\r\n`/api/security/v1/oidc` (GET)\r\n-
#47929 - `8.0.0`,
dropped\r\n`/api/security/v1/saml` (`breaking` release note)\r\n-
#106665 -
restored\r\n`/api/security/v1/saml` but warned as deprecated (no release
note)\r\n\r\n## Testing\r\n1. Start ES & Kibana in trial license
mode\r\n2. Make several calls to one or more of the deprecated
endpoints\r\n3. Navigate to `Stack Management`->`Upgrade
Assistant`\r\n4. Click on Kibana warnings\r\n<img width=\"1003\"
alt=\"Screenshot 2024-11-18 at 10 01
10 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/da44af13-57eb-4ffd-a507-e423eb767a11\">\r\n5.
Confirm the called endpoints are displayed as warnings in the
Upgrade\r\nAssistant\r\n<img width=\"1274\" alt=\"Screenshot 2024-11-18
at 9 59
34 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/4c054fbe-6838-48cf-8b1b-8c161252db0f\">\r\n\r\n##
Previous release notes \r\n###
v7.6.0\r\n\r\nhttps://www.elastic.co/guide/en/kibana/7.6/release-notes-7.6.0.html#deprecation-7.6.0\r\nhttps://www.elastic.co/guide/en/kibana/7.6/breaking-changes-7.6.html\r\nThe
deprecations are not listed in the release notes or breaking
changes\r\nnotes.\r\n\r\n###
v8.0.0\r\n\r\nhttps://www.elastic.co/guide/en/kibana/current/release-notes-8.0.0-alpha1.html#rest-api-changes\r\nSAML
endpoint deprecation only appears in the 8.0.0-alpha1 release\r\nnotes,
and was reverted in 8.0.0-alpha2\r\n\r\n# Release note\r\nSee
`docs/upgrade-notes.asciidoc` in file changes\r\n\r\n# Follow-up\r\nA
follow-up PR must be created to create and backfill the
docLinks.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"742ae9fd2a255d5ba15100d644e7de3540e28f60","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:deprecation","Team:Security","backport
missing","v9.0.0","backport:prev-minor","v8.18.0"],"number":199656,"url":"https://github.com/elastic/kibana/pull/199656","mergeCommit":{"message":"Surface
Kibana security route deprecations in Upgrade Assistant
(#199656)\n\nCloses #197389\r\n\r\n## Summary\r\n\r\nUses the
`deprecated` route configuration option on all Kibana Security\r\n\"v1\"
endpoints. This will surface deprecation information in the
Upgrade\r\nAssistant.\r\n\r\n## Related PRs\r\n-
#50695 - `7.6.0`, deprecated\r\n -
`/api/security/v1/me`\r\n - `/api/security/v1/logout`\r\n -
`/api/security/v1/oidc/implicit`\r\n - `/api/security/v1/oidc`
(POST)\r\n- #53886 - `7.6.0`,
deprecated\r\n`/api/security/v1/oidc` (GET)\r\n-
#47929 - `8.0.0`,
dropped\r\n`/api/security/v1/saml` (`breaking` release note)\r\n-
#106665 -
restored\r\n`/api/security/v1/saml` but warned as deprecated (no release
note)\r\n\r\n## Testing\r\n1. Start ES & Kibana in trial license
mode\r\n2. Make several calls to one or more of the deprecated
endpoints\r\n3. Navigate to `Stack Management`->`Upgrade
Assistant`\r\n4. Click on Kibana warnings\r\n<img width=\"1003\"
alt=\"Screenshot 2024-11-18 at 10 01
10 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/da44af13-57eb-4ffd-a507-e423eb767a11\">\r\n5.
Confirm the called endpoints are displayed as warnings in the
Upgrade\r\nAssistant\r\n<img width=\"1274\" alt=\"Screenshot 2024-11-18
at 9 59
34 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/4c054fbe-6838-48cf-8b1b-8c161252db0f\">\r\n\r\n##
Previous release notes \r\n###
v7.6.0\r\n\r\nhttps://www.elastic.co/guide/en/kibana/7.6/release-notes-7.6.0.html#deprecation-7.6.0\r\nhttps://www.elastic.co/guide/en/kibana/7.6/breaking-changes-7.6.html\r\nThe
deprecations are not listed in the release notes or breaking
changes\r\nnotes.\r\n\r\n###
v8.0.0\r\n\r\nhttps://www.elastic.co/guide/en/kibana/current/release-notes-8.0.0-alpha1.html#rest-api-changes\r\nSAML
endpoint deprecation only appears in the 8.0.0-alpha1 release\r\nnotes,
and was reverted in 8.0.0-alpha2\r\n\r\n# Release note\r\nSee
`docs/upgrade-notes.asciidoc` in file changes\r\n\r\n# Follow-up\r\nA
follow-up PR must be created to create and backfill the
docLinks.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"742ae9fd2a255d5ba15100d644e7de3540e28f60"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199656","number":199656,"mergeCommit":{"message":"Surface
Kibana security route deprecations in Upgrade Assistant
(#199656)\n\nCloses #197389\r\n\r\n## Summary\r\n\r\nUses the
`deprecated` route configuration option on all Kibana Security\r\n\"v1\"
endpoints. This will surface deprecation information in the
Upgrade\r\nAssistant.\r\n\r\n## Related PRs\r\n-
#50695 - `7.6.0`, deprecated\r\n -
`/api/security/v1/me`\r\n - `/api/security/v1/logout`\r\n -
`/api/security/v1/oidc/implicit`\r\n - `/api/security/v1/oidc`
(POST)\r\n- #53886 - `7.6.0`,
deprecated\r\n`/api/security/v1/oidc` (GET)\r\n-
#47929 - `8.0.0`,
dropped\r\n`/api/security/v1/saml` (`breaking` release note)\r\n-
#106665 -
restored\r\n`/api/security/v1/saml` but warned as deprecated (no release
note)\r\n\r\n## Testing\r\n1. Start ES & Kibana in trial license
mode\r\n2. Make several calls to one or more of the deprecated
endpoints\r\n3. Navigate to `Stack Management`->`Upgrade
Assistant`\r\n4. Click on Kibana warnings\r\n<img width=\"1003\"
alt=\"Screenshot 2024-11-18 at 10 01
10 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/da44af13-57eb-4ffd-a507-e423eb767a11\">\r\n5.
Confirm the called endpoints are displayed as warnings in the
Upgrade\r\nAssistant\r\n<img width=\"1274\" alt=\"Screenshot 2024-11-18
at 9 59
34 AM\"\r\nsrc=\"https://github.com/user-attachments/assets/4c054fbe-6838-48cf-8b1b-8c161252db0f\">\r\n\r\n##
Previous release notes \r\n###
v7.6.0\r\n\r\nhttps://www.elastic.co/guide/en/kibana/7.6/release-notes-7.6.0.html#deprecation-7.6.0\r\nhttps://www.elastic.co/guide/en/kibana/7.6/breaking-changes-7.6.html\r\nThe
deprecations are not listed in the release notes or breaking
changes\r\nnotes.\r\n\r\n###
v8.0.0\r\n\r\nhttps://www.elastic.co/guide/en/kibana/current/release-notes-8.0.0-alpha1.html#rest-api-changes\r\nSAML
endpoint deprecation only appears in the 8.0.0-alpha1 release\r\nnotes,
and was reverted in 8.0.0-alpha2\r\n\r\n# Release note\r\nSee
`docs/upgrade-notes.asciidoc` in file changes\r\n\r\n# Follow-up\r\nA
follow-up PR must be created to create and backfill the
docLinks.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"742ae9fd2a255d5ba15100d644e7de3540e28f60"}},{"branch":"8.18","label":"v8.18.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@jeramysoucy @kibanamachine @CAWilson94
Surface Kibana security route deprecations in Upgrade Assistant (elas…
8bf9487 
…tic#199656)

Closes elastic#197389

## Summary

Uses the `deprecated` route configuration option on all Kibana Security
"v1" endpoints. This will surface deprecation information in the Upgrade
Assistant.

## Related PRs
- elastic#50695 - `7.6.0`, deprecated
    - `/api/security/v1/me`
    - `/api/security/v1/logout`
    - `/api/security/v1/oidc/implicit`
    - `/api/security/v1/oidc` (POST)
- elastic#53886 - `7.6.0`, deprecated
`/api/security/v1/oidc` (GET)
- elastic#47929 - `8.0.0`, dropped
`/api/security/v1/saml` (`breaking` release note)
- elastic#106665 - restored
`/api/security/v1/saml` but warned as deprecated (no release note)

## Testing
1.  Start ES & Kibana in trial license mode
2. Make several calls to one or more of the deprecated endpoints
3. Navigate to `Stack Management`->`Upgrade Assistant`
4. Click on Kibana warnings
<img width="1003" alt="Screenshot 2024-11-18 at 10 01 10 AM"
src="https://github.com/user-attachments/assets/da44af13-57eb-4ffd-a507-e423eb767a11">
5. Confirm the called endpoints are displayed as warnings in the Upgrade
Assistant
<img width="1274" alt="Screenshot 2024-11-18 at 9 59 34 AM"
src="https://github.com/user-attachments/assets/4c054fbe-6838-48cf-8b1b-8c161252db0f">

## Previous release notes 
### v7.6.0

https://www.elastic.co/guide/en/kibana/7.6/release-notes-7.6.0.html#deprecation-7.6.0
https://www.elastic.co/guide/en/kibana/7.6/breaking-changes-7.6.html
The deprecations are not listed in the release notes or breaking changes
notes.

### v8.0.0

https://www.elastic.co/guide/en/kibana/current/release-notes-8.0.0-alpha1.html#rest-api-changes
SAML endpoint deprecation only appears in the 8.0.0-alpha1 release
notes, and was reverted in 8.0.0-alpha2

# Release note
See `docs/upgrade-notes.asciidoc` in file changes

# Follow-up
A follow-up PR must be created to create and backfill the docLinks.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legrego legrego legrego approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Security/Authentication Platform Security - Authentication release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azasypkin @elasticmachine @kibanamachine @legrego