[maps] remove xpack.maps.showMapVisualizationTypes

[nreese]

Remove xpack.maps.showMapVisualizationTypes kibana.yml settings. With removal of tile_map and region_map plugins, this setting no longer has any use.

Telemetry checker updates:

This PR adds a couple of previously unsupported features in the telemetry_check parser.

@Bamieh pushed fixes needed by telemtry to support enums in type interface collector. These changes were required to resolve telemetry build failures between the schema and the usage ts Type matches.

Added in the same PR rather than a separate one to help unblock this PR faster.

Add support for computed terms:

Usage type

const COMPUTED_TERM = 'computed_term';
interface CONSTANT_TERM_INTERFACE {
  [COMPUTED_TERM]?: number;
}
interface Usage {
   computed_interface: CONSTANT_TERM_INTERFACE
}

Schema

{
   computed_interface: {
      computed_term: { type: 'float' }
   }
}

Add support for enums

Usage type

enum TELEMETRY_LAYER_TYPE {
  ES_DOCS = 'es_docs',
  ES_TOP_HITS = 'es_top_hits',
}

interface ClusterCountStats {
  min: number;
  max: number;
  total: number;
  avg: number;
}

type TELEMETRY_LAYER_TYPE_COUNTS_PER_CLUSTER = {
  [key in TELEMETRY_LAYER_TYPE]?: ClusterCountStats;
};

interface Usage {
  layerTypes: TELEMETRY_LAYER_TYPE_COUNTS_PER_CLUSTER;
}

Schema

{
  layerTypes: {
    es_top_hits: {
      min: { type: 'long', _meta: { description: 'min number of es top hits layers per map' } },
      max: { type: 'long', _meta: { description: 'max number of es top hits layers per map' } },
      avg: {
        type: 'float',
        _meta: { description: 'avg number of es top hits layers per map' },
      },
      total: {
        type: 'long',
        _meta: { description: 'total number of es top hits layers in cluster' },
      },
    },
  }
}

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[joshdover]

Was this configuration already deprecated on the 7.x branch? I'm not finding a deprecation notice in the source tree.

[thomasneirynck]

@joshdover What do you mean exactly with "deprecated". ie. logging a warning message on startup? fyi #105981

[nreese]

@elasticmachine merge upstream

[nreese]

@elasticmachine merge upstream

[afharo]

LGTM! Just added 1 NIT. Thanks for extending our @kbn/telemetry-tools

[spalger]

Operations: LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: c7f9999
• Storybooks Preview
• Documentation Changes

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
maps	79.3KB	79.2KB	-86.0B

History

• 💔 Build #147847 failed 0afc4a4
• 💔 Build #147829 failed db3df9a
• 💔 Build #147776 failed da1c6d4
• 💔 Build #146963 failed c76dc83
• 💔 Build #146760 failed caa8035

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[thomasneirynck]

thx, tested and works. Super nice to see this come together.

fwiw - only looked at maps-changes, not the telemetry ones.

We will also need to remove the corresponding configuration from Cloud.

https://github.com/elastic/cloud/search?q=xpack.maps.showMapVisualizationTypes

Could you open a corresponding issue in the Cloud repo? I think these types of changes are handled in batch on the cloud-side. Thx.

[nreese]

Could you open a corresponding issue in the Cloud repo? I think these types of changes are handled in batch on the cloud-side. Thx.

Created https://github.com/elastic/cloud/issues/87294 to track removal of xpack.maps.showMapVisualizationTypes in cloud

[kibanamachine]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 105979 or prevent reminders by adding the backport:skip label.

[nreese]

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 105979 or prevent reminders by adding the backport:skip label.

Added backport:skip label. This change is 8.0 only