Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jul 14, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 32.0.0 -> 33.0.0 age adoption passing confidence

Release Notes

elastic/elastic-charts

v33.0.0

Compare Source

Features
BREAKING CHANGES
  • xy: an API change is introduced: hideClippedValue is removed in favor of overflowConstraints?: Array<LabelOverflowConstraint>;. The array can contain one or multiple overflow constraints enumerated as LabelOverflowConstraint

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels Jul 14, 2021
@renovate renovate bot requested review from markov00 and nickofthyme July 14, 2021 16:15
@nickofthyme
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@nickofthyme
Copy link
Contributor

@elasticmachine merge upstream

@renovate renovate bot requested a review from a team July 16, 2021 14:38
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes are purely semantic.

displayValueSettings={{
-  hideClippedValue: true,
+  overflowConstraints: [LabelOverflowConstraint.ChartEdges],
}}

@nickofthyme
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@nickofthyme nickofthyme enabled auto-merge (squash) July 16, 2021 14:42
@nickofthyme nickofthyme disabled auto-merge July 16, 2021 14:42
@nickofthyme nickofthyme enabled auto-merge (squash) July 16, 2021 14:42
@nickofthyme
Copy link
Contributor

ping @elastic/kibana-app

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +75.0B
visTypeXy 113.0KB 113.1KB +150.0B
total +225.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-elastic 2.6MB 2.6MB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think that this is a great addition. I checked both Lens and XY. If we change a bit the font size and other settings I think we can improve a lot the way we display the labels inside the bars. Thanx a lot team :)

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@nickofthyme nickofthyme merged commit 1e30148 into master Jul 20, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 105633

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 20, 2021
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (187 commits)
  Space management page UX improvements (elastic#100448)
  [Reporting] Unskip flaky test when downloading CSV with "no data" (elastic#105252)
  Update dependency @elastic/charts to v33 (master) (elastic#105633)
  [Observability RAC] Improve alerts table columns (elastic#105446)
  Introduce `preboot` lifecycle stage (elastic#103636)
  [Security Solution] Invalid kql query timeline refresh bug (elastic#105525)
  skip flaky suite (elastic#106121)
  [Security Solution][Endpoint] Fix UI inconsistency between isolation forms and remove display of Pending isolation statuses (elastic#106118)
  docs: APM RUM Source map API (elastic#105332)
  [CTI] Adds indicator match rule improvements (elastic#97310)
  [Security Solution] update text for Isolation action submissions (elastic#105956)
  EP Meta Telemetry Perf (elastic#104396)
  [Metrics UI] Drop partial buckets from ALL Metrics UI queries (elastic#104784)
  Remove beta admonitions for Fleet docs (elastic#106010)
  [Observability RAC] Remove indexing of rule evaluation documents (elastic#104970)
  Parameterize migration test for kibana version (elastic#105417)
  [Alerting] Allow rule to execute if the value is 0 and that mets the condition (elastic#105626)
  [ML] Fix Index data visualizer sometimes shows wrong doc count for saved searches (elastic#106007)
  [Security Solution] UX fixes for Policy page and Case Host Isolation comment (elastic#106027)
  [Security Solution]Memory protection configuration card for policies integration. (elastic#101365)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
#	x-pack/plugins/reporting/public/management/report_listing.tsx
nickofthyme added a commit that referenced this pull request Jul 20, 2021
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants