Skip to content

[ML] Fix calendar creation during model snapshot restore#105421

Merged
jgowdyelastic merged 2 commits intoelastic:masterfrom
jgowdyelastic:fix-calendar-creation-during-model-snapshot-restore
Jul 13, 2021
Merged

[ML] Fix calendar creation during model snapshot restore#105421
jgowdyelastic merged 2 commits intoelastic:masterfrom
jgowdyelastic:fix-calendar-creation-during-model-snapshot-restore

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic commented Jul 13, 2021 •
edited
Loading

An empty event_id is being added to the events being created when adding calendars during a snapshot restore.

Bug introduced here #83808
Looks like the empty id was added to work around incorrect esclient types.

Also adds a catch for any other unexpected errors when applying a snapshot

@jgowdyelastic jgowdyelastic added review release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 13, 2021
@jgowdyelastic jgowdyelastic self-assigned this Jul 13, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 13, 2021 12:09
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 13, 2021

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 13, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +133.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit e300a75 into elastic:master Jul 13, 2021
@jgowdyelastic jgowdyelastic deleted the fix-calendar-creation-during-model-snapshot-restore branch July 13, 2021 18:11
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 13, 2021
@jgowdyelastic @kibanamachine
[ML] Fix calendar creation during model snapshot restore (elastic#105421
7d8bf0d 
)

* [ML] Fix calendar creation during model snapshot restore

* adding toast for unexpected errors
This was referenced Jul 13, 2021
Merged
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 13, 2021
@jgowdyelastic @kibanamachine
[ML] Fix calendar creation during model snapshot restore (elastic#105421
b9a1851 
)

* [ML] Fix calendar creation during model snapshot restore

* adding toast for unexpected errors
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 13, 2021

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 13, 2021
@kibanamachine @jgowdyelastic
[ML] Fix calendar creation during model snapshot restore (#105421) (#…
9d092d2 
…105487)

* [ML] Fix calendar creation during model snapshot restore

* adding toast for unexpected errors

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 13, 2021
@kibanamachine @jgowdyelastic
[ML] Fix calendar creation during model snapshot restore (#105421) (#…
fc715e6 
…105488)

* [ML] Fix calendar creation during model snapshot restore

* adding toast for unexpected errors

Co-authored-by: James Gowdy <jgowdy@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@jgowdyelastic jgowdyelastic

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.14.0 v7.15.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgowdyelastic @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson