[ML] Fix "View by" swim lane with applied filter and sorting by score #105217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
|
Not related to the changes in this PR, as I can reproduce this with and without these changes, but for reference, here is an example of how sometimes the clicked on Top influencer doesn't end up populating the query bar:
|
peteharverson
approved these changes
Jul 12, 2021
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and LGTM. Noted for reference a remaining issue where a filter applied from the Top Influencers list sometimes doesn't populate the query bar.
peteharverson
approved these changes
Jul 12, 2021
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest edit and LGTM
Contributor
Author
|
@elasticmachine merge upstream |
alvarezmelissa87
approved these changes
Jul 12, 2021
Contributor
alvarezmelissa87
left a comment
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Tested and LGTM ⚡
Contributor
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @darnautov |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 13, 2021
…elastic#105217) * [ML] fix top influencers fetch with filter selection * [ML] add relative position to the chart container * [ML] fix ts * [ML] fix updating search input from influencer filter
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 13, 2021
…elastic#105217) * [ML] fix top influencers fetch with filter selection * [ML] add relative position to the chart container * [ML] fix ts * [ML] fix updating search input from influencer filter
Contributor
kibanamachine
added a commit
that referenced
this pull request
Jul 13, 2021
…#105217) (#105391) * [ML] fix top influencers fetch with filter selection * [ML] add relative position to the chart container * [ML] fix ts * [ML] fix updating search input from influencer filter Co-authored-by: Dima Arnautov <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Jul 13, 2021
…#105217) (#105392) * [ML] fix top influencers fetch with filter selection * [ML] add relative position to the chart container * [ML] fix ts * [ML] fix updating search input from influencer filter Co-authored-by: Dima Arnautov <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 13, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (292 commits) bring back KQL autocomplete in timeline + fix last updated (elastic#105380) [Maps] Change TOC pop-up wording to reflect filter change, not search bar change (elastic#105163) Updating urls to upstream elastic repo (elastic#105250) [Maps] Move new vector layer wizard card down (elastic#104797) Exclude registering the cases feature if not enabled (elastic#105292) [Uptime] Alerts - Monitor status alert - check monitor status by monitor.timespan (elastic#104541) updated UI copy (elastic#105184) Log a warning when documents of unknown types are detected during migration (elastic#105213) [Logs UI] Register log threshold rule as lifecycle rule (elastic#104341) [Ingest pipelines] add network direction processor (elastic#103436) [Console] Autocomplete definitions (manual backport) (elastic#105086) [Security Solution] User can make Exceptions for Memory protection alerts (elastic#102196) [Lens] Formula: add validation for multiple field/metrics (elastic#104092) Removing async from file upload and data visualizer plugins start lifecycle (elastic#105197) Fix error when validating the form with non blocking validations (elastic#103629) [ML] Fix "View by" swim lane with applied filter and sorting by score (elastic#105217) Update dependency @elastic/charts to v32 (elastic#104625) [CTI] shortens large numbers on Dashboard Link Panel (elastic#105269) [Security Solution][Endpoint][Host Isolation] Fixes bug to remove excess host metadata status toasts on non user initiated errors (elastic#105331) [Cases] Fix pushing alerts count on every push to external service (elastic#105030) ... # Conflicts: # x-pack/plugins/reporting/common/types.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures the 'view by' swim lane is always displayed in the Anomaly Explorer when a filter has been applied to the view, but at the time of the selected cell in the 'overall' swim lane the influencer score for the filtered entity(s) is zero.
Before:
After:
Checklist