[App Search] Disable crawler nav link & route for sample & meta engines#104693
Closed
cee-chen wants to merge 4 commits intoelastic:masterfrom
Closed
[App Search] Disable crawler nav link & route for sample & meta engines#104693cee-chen wants to merge 4 commits intoelastic:masterfrom
cee-chen wants to merge 4 commits intoelastic:masterfrom
Conversation
- Adding this to silo our business logic in our logic files rather than our views. Also makes it cleaner if we ever expand restrictions on engines that show the crawler
- to match its corresponding nav link
cee-chen
added
bug
Contributor
Author
|
Per Casey/product, we're leaving Crawler in sample engine after all. I'll close this, but I might open another PR with just 4932382 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per product, the Crawler link/route should not available for the
national-parks-demosample engine.Also while I was here, I noticed the source engines route didn't have an
isMetaEnginecheck like its nav link did, so I updated that as well.Checklist