[Fleet] Link to download page of current stack version on Agent install instructions by Zacqary · Pull Request #104494 · elastic/kibana

Zacqary · 2021-07-06T16:21:08Z

Summary

Closes #102491

Links the Go to download page button to the past-releases URL matching the current Kibana version.

Also adds instructions on using the Linux installer over RPM/DEB, as these aren't present on the past release page:

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

elasticmachine · 2021-07-06T16:21:11Z

Pinging @elastic/fleet (Team:Fleet)

elasticmachine · 2021-07-06T16:21:11Z

Pinging @elastic/fleet (Feature:Fleet)

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/steps.tsx

kibanamachine · 2021-07-06T20:44:38Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	483	516	+33

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	715.8KB	737.3KB	+21.5KB

History

💔 Build #136637 failed da26bcc
💔 Build #136620 failed 603e340

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Zacqary

kpollich

LGTM 🚀

jen-huang · 2021-07-07T15:43:15Z

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/steps.tsx

        <EuiSpacer size="l" />
        <EuiButton
-          href="https://ela.st/download-elastic-agent"
+          href={`https://www.elastic.co/downloads/past-releases/elastic-agent-${kibanaVersionURLString}`}


one thing that will be annoying, is that this link will be broken for releases which are not published yet (i.e. local development from master/8.0.0, build candidates like the upcoming 7.14.0)

but I'm not sure what we can do about that. @mostlyjason WDYT?

I was concerned about that too, but there doesn't seem to be an easy way to determine in the code whether or not a version is released yet. This might just have to be a thing we deal with in development.

sgtm 👍🏻

mostlyjason · 2021-07-07T16:17:07Z

LGTM. Minor thing: there is only one installer for Linux so it can be singular

jfsiii · 2021-07-07T17:06:33Z

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/steps.tsx


 export const DownloadStep = () => {
+  const kibanaVersion = useKibanaVersion();
+  const kibanaVersionURLString = useMemo(


It's not a blocker for me, but in the main branch this will go to https://www.elastic.co/downloads/past-releases/elastic-agent-8-0-0 which 404's.

I don't know if it's better to leave the existing https://ela.st/download-elastic-agent for snapshot builds or use this invalid URL

One optional enhancement for another time/PR is to use the results from https://artifacts-api.elastic.co/v1/search/8.0-SNAPSHOT/elastic-agent to make a list of links like below (in the flyout?)

None of these are requirements to ship, IMO; just pointing out what I noticed

…ll instructions (elastic#104494) * [Fleet] Link to download page of current stack version * Get Kibana version from semver function * Fix jest

kibanamachine · 2021-07-07T17:57:34Z

💚 Backport successful

Status	Branch	Result
✅	7.14
✅	7.x

The backport PRs will be merged automatically after passing CI.

…ll instructions (#104494) (#104730) * [Fleet] Link to download page of current stack version * Get Kibana version from semver function * Fix jest Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

…ll instructions (#104494) (#104731) * [Fleet] Link to download page of current stack version * Get Kibana version from semver function * Fix jest Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>

…-of-max-results * 'master' of github.com:elastic/kibana: (36 commits) Lower Kibana app bundle limits (elastic#104688) [Security Solutions] Fixes bug with the filter query compatibility for transforms (elastic#104559) [RAC] Add mapping update logic to RuleDataClient (elastic#102586) Fix import workpad (elastic#104722) [canvas] Fix Storybook service decorator (elastic#104750) [Detection Rules] Add 7.14 rules (elastic#104772) [Enterprise Search] Fix beta notification in sidebar (elastic#104763) Fix engine routes that are meta engine or non-meta-engine specific (elastic#104757) [Fleet] Fix policy revision number getting bumped for no reason (elastic#104696) persistable state migrations (elastic#103680) [Fleet] Fix add agent in the package policy table (elastic#104749) [DOCS] Creates separate doc for security in production (elastic#103973) [SO Migration] fix reindex race on multi-instance mode (elastic#104516) [Security Solution] Update text in Endpoint Admin pages (elastic#104649) [package testing] Decrease timeout to 2 hours (elastic#104668) Fix background styling of waterfall chart sidebar tooltip. (elastic#103997) [Fleet + Integrations UI] Integrations UI Cleanup (elastic#104641) [Fleet] Link to download page of current stack version on Agent install instructions (elastic#104494) [Workplace Search] Fix Media Type field preview is unformatted bug (elastic#104684) [ML] add marker body (elastic#104672) ... # Conflicts: # x-pack/plugins/fleet/public/search_provider.test.ts

[Fleet] Link to download page of current stack version

603e340

Zacqary added release_note:fix v8.0.0 Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v7.15.0 labels Jul 6, 2021

Zacqary self-assigned this Jul 6, 2021

Zacqary requested a review from a team as a code owner July 6, 2021 16:21

jen-huang reviewed Jul 6, 2021

View reviewed changes

x-pack/plugins/fleet/public/components/agent_enrollment_flyout/steps.tsx Outdated Show resolved Hide resolved

Zacqary added 2 commits July 6, 2021 11:55

Get Kibana version from semver function

da26bcc

Fix jest

51e6b73

kpollich approved these changes Jul 7, 2021

View reviewed changes

jen-huang reviewed Jul 7, 2021

View reviewed changes

Zacqary added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 7, 2021

jfsiii reviewed Jul 7, 2021

View reviewed changes

Zacqary merged commit e3b6c1f into elastic:master Jul 7, 2021

kibanamachine mentioned this pull request Jul 7, 2021

[7.14] [Fleet] Link to download page of current stack version on Agent install instructions (#104494) #104730

Merged

kibanamachine mentioned this pull request Jul 7, 2021

[7.x] [Fleet] Link to download page of current stack version on Agent install instructions (#104494) #104731

Merged

EricDavisX mentioned this pull request Aug 12, 2021

[Fleet] Download Agent link points to prior release page #108414

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Link to download page of current stack version on Agent install instructions#104494

[Fleet] Link to download page of current stack version on Agent install instructions#104494
Zacqary merged 3 commits intoelastic:masterfrom
Zacqary:102491-download-page-link

Zacqary commented Jul 6, 2021

Uh oh!

elasticmachine commented Jul 6, 2021

Uh oh!

elasticmachine commented Jul 6, 2021

Uh oh!

Uh oh!

kibanamachine commented Jul 6, 2021

Uh oh!

kpollich left a comment

Uh oh!

jen-huang Jul 7, 2021

Uh oh!

Zacqary Jul 7, 2021

Uh oh!

jen-huang Jul 7, 2021

Uh oh!

mostlyjason commented Jul 7, 2021

Uh oh!

jfsiii Jul 7, 2021

Uh oh!

kibanamachine commented Jul 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Zacqary commented Jul 6, 2021

Summary

Checklist

Uh oh!

elasticmachine commented Jul 6, 2021

Uh oh!

elasticmachine commented Jul 6, 2021

Uh oh!

Uh oh!

kibanamachine commented Jul 6, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

jen-huang Jul 7, 2021

Choose a reason for hiding this comment

Uh oh!

Zacqary Jul 7, 2021

Choose a reason for hiding this comment

Uh oh!

jen-huang Jul 7, 2021

Choose a reason for hiding this comment

Uh oh!

mostlyjason commented Jul 7, 2021

Uh oh!

jfsiii Jul 7, 2021

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jul 7, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants