[5.x] Adding attributes to be used by sharing#10425
Merged
Conversation
Backports PR #10234 **Commit 1:** Adding attributes to be used by sharing * Original sha: cbb5047 * Authored by kobelb <brandon.kobel@elastic.co> on 2017-01-25T15:53:10Z **Commit 2:** Moving the shared-item tags for dashboard panels * Original sha: ba4b74b * Authored by kobelb <brandon.kobel@elastic.co> on 2017-02-07T20:27:36Z **Commit 3:** Switching from shared-item-title/description to just title/description * Original sha: 757d7cf * Authored by kobelb <brandon.kobel@elastic.co> on 2017-02-07T20:31:09Z **Commit 4:** Removing move noise * Original sha: c54df9f * Authored by kobelb <brandon.kobel@elastic.co> on 2017-02-07T20:33:19Z **Commit 5:** Fixing typo * Original sha: 7a13bc9 * Authored by kobelb <brandon.kobel@elastic.co> on 2017-02-07T20:34:18Z **Commit 6:** Adding data- prefix before attributes, began writing tests Adding shared-item title tests Switching up the panel tests Adding description tests Fixing linting Adding dashboard timefilter test Adding visualization shared-item tests Adding shared-timefilter tests Adding discover shared-item tests * Original sha: 0dbb7eb * Authored by kobelb <brandon.kobel@elastic.co> on 2017-02-09T19:39:13Z **Commit 7:** Fixing shared-items-count on dashboard * Original sha: 7ab7a70 * Authored by kobelb <brandon.kobel@elastic.co> on 2017-02-16T14:25:58Z **Commit 8:** Fixing functional test data for discover and visualize * Original sha: 063a49e * Authored by kobelb <brandon.kobel@elastic.co> on 2017-02-16T20:57:22Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding attributes to be used by sharing
Backports PR #10234
Commit 1:
Adding attributes to be used by sharing
Commit 2:
Moving the shared-item tags for dashboard panels
Commit 3:
Switching from shared-item-title/description to just title/description
Commit 4:
Removing move noise
Commit 5:
Fixing typo
Commit 6:
Adding data- prefix before attributes, began writing tests
Adding shared-item title tests
Switching up the panel tests
Adding description tests
Fixing linting
Adding dashboard timefilter test
Adding visualization shared-item tests
Adding shared-timefilter tests
Adding discover shared-item tests
Commit 7:
Fixing shared-items-count on dashboard
Commit 8:
Fixing functional test data for discover and visualize