Skip to content

[ML] Data visualizer: Removes experimental badge from file data visualizer#104075

Merged
peteharverson merged 2 commits intoelastic:masterfrom
peteharverson:ml-file-data-viz-remove-experimental
Jul 1, 2021
Merged

[ML] Data visualizer: Removes experimental badge from file data visualizer#104075
peteharverson merged 2 commits intoelastic:masterfrom
peteharverson:ml-file-data-viz-remove-experimental

Conversation

@peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jul 1, 2021

Summary

Removes the 'Experimental' label from the file data visualizer / file upload pages.

  • File / Index selector page in the ML Data Visualizer
    image

  • File data visualizer - select file page
    image

  • File upload - import page
    image

@peteharverson peteharverson added review :ml cosmetic v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer v7.14.0 v7.15.0 labels Jul 1, 2021
@peteharverson peteharverson self-assigned this Jul 1, 2021
@peteharverson peteharverson requested review from a team as code owners July 1, 2021 10:26
jgowdyelastic
jgowdyelastic approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 1, 2021

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 1, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dataVisualizer 238 236 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 1.1MB 1.1MB -2.4KB
ml 5.9MB 5.9MB -427.0B
total -2.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@qn895
Copy link
Member

qn895 commented Jul 1, 2021

Tested and LGTM

@peteharverson peteharverson added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 1, 2021
@peteharverson peteharverson merged commit 03c7131 into elastic:master Jul 1, 2021
@peteharverson peteharverson deleted the ml-file-data-viz-remove-experimental branch July 1, 2021 16:57
@kibanamachine kibanamachine mentioned this pull request Jul 1, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 1, 2021
@peteharverson @kibanamachine
[ML] Data visualizer: Removes experimental badge from file data visua…
248f5e7 
…lizer (elastic#104075)

* [ML] Data visualizer: Removes experimental badge from file data visualizer

* [ML] Remove experimental badge scss import
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 1, 2021
@peteharverson @kibanamachine
[ML] Data visualizer: Removes experimental badge from file data visua…
541123a 
…lizer (elastic#104075)

* [ML] Data visualizer: Removes experimental badge from file data visualizer

* [ML] Remove experimental badge scss import
@kibanamachine kibanamachine mentioned this pull request Jul 1, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 1, 2021

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 1, 2021
@kibanamachine @peteharverson
[ML] Data visualizer: Removes experimental badge from file data visua…
c54e9a6 
…lizer (#104075) (#104151)

* [ML] Data visualizer: Removes experimental badge from file data visualizer

* [ML] Remove experimental badge scss import

Co-authored-by: Pete Harverson <peteharverson@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 1, 2021
@kibanamachine @peteharverson
[ML] Data visualizer: Removes experimental badge from file data visua…
d8d5bf7 
…lizer (#104075) (#104150)

* [ML] Data visualizer: Removes experimental badge from file data visualizer

* [ML] Remove experimental badge scss import

Co-authored-by: Pete Harverson <peteharverson@users.noreply.github.com>
@lcawl lcawl mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@peteharverson peteharverson

Labels

auto-backport Deprecated - use backport:version if exact versions are needed cosmetic Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:skip Skip the PR/issue when compiling release notes review v7.14.0 v7.15.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peteharverson @elasticmachine @kibanamachine @qn895 @jgowdyelastic